Issue 83310044: fix 1300032: charm: gccgo test failure

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by waigani

Modified:
10 years, 1 month ago

Reviewers:
axw, dave, mp+213755, fwereade

Visibility:
Public.

Description

fix 1300032: charm: gccgo test failure When network is down, http-proxy returns an error in html format, hence the leading '<'. Ensure the response code is 200, otherwise return an error. https://code.launchpad.net/~waigani/juju-core/gccgo-charm-1300032/+merge/213755 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : fix 1300032: charm: gccgo test failure #

Patch Set 3 : fix 1300032: charm: gccgo test failure #

Patch Set 4 : fix 1300032: charm: gccgo test failure #

Patch Set 5 : fix 1300032: charm: gccgo test failure #

Total comments: 2

Patch Set 6 : fix 1300032: charm: gccgo test failure #

Total comments: 2

Patch Set 7 : fix 1300032: charm: gccgo test failure #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
A	[revision details]	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/repo.go	View	1 2 3 4 5 6	1 chunk	+9 lines, -0 lines	0 comments	Download
M	charm/repo_test.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 15

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2014/04/02 03:15:43, waigani wrote: > Please take a look. Hang on a sec. The ...

10 years, 1 month ago (2014-04-02 03:21:45 UTC) #4

fwereade

I'm a bit uncertain about this too. Is the issue that we go through the ...

10 years, 1 month ago (2014-04-02 07:16:40 UTC) #5

waigani

On 2014/04/02 03:21:45, dfc wrote: > On 2014/04/02 03:15:43, waigani wrote: > > Please take ...

10 years, 1 month ago (2014-04-03 00:16:58 UTC) #6

On 2014/04/02 03:21:45, dfc wrote:
> On 2014/04/02 03:15:43, waigani wrote:
> > Please take a look.
> 
> Hang on a sec. The proxy is returning some blocked page, is that coming back
> with a 200 response ?

On 2014/04/02 07:16:40, fwereade wrote:
> I'm a bit uncertain about this too. Is the issue that we go through the proxy
> when trying to get stuff from localhost? ISTM that (1) we'll need a more
general
> solution, there are plenty of tests that use local http servers and (2) surely
> we can just no-proxy localhost and have the same effect?
> 
> I'm almost certainly misunderstanding something here, though, so it may be
that
> all I need is some clarification :). WIP pending same.

It returns a 403 access denied error. Details below.

Response Headers:

[LOG] 36.85478 DEBUG juju &http.Response{Status:"403 Forbidden", StatusCode:403,
Proto:"HTTP/1.0", ProtoMajor:1, ProtoMinor:0,
Header:http.Header{"Connection":[]string{"close"},
"X-Squid-Error":[]string{"ERR_ACCESS_DENIED 0"}, "X-Cache-Lookup":[]string{"NONE
from batuan.canonical.com:3128"}, "X-Cache":[]string{"MISS from
batuan.canonical.com"}, "Date":[]string{"Wed, 02 Apr 2014 23:59:06 GMT"},
"Content-Length":[]string{"1189"}, "Content-Type":[]string{"text/html"},
"Server":[]string{"squid/2.7.STABLE7"}, "Via":[]string{"1.0
batuan.canonical.com:3128 (squid/2.7.STABLE7)"}},
Body:(*http.bodyEOFSignal)(0xc214ac6180), ContentLength:1189,
TransferEncoding:[]string(nil), Close:true, Trailer:http.Header(nil),
Request:(*http.Request)(0xc210435a90)}

Response Body:

[LOG] 36.85478 DEBUG juju "<!DOCTYPE html PUBLIC \"-//W3C//DTD HTML 4.01//EN\"
\"http://www.w3.org/TR/html4/strict.dtd\"> <html><head> <meta
http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\"> <title>ERROR:
The requested URL could not be retrieved</title> <style type=\"text/css\"><!-- 
%l  body :lang(fa) { direction: rtl; font-size: 100%; font-family: Tahoma, Roya,
sans-serif; float: right; } :lang(he) { direction: rtl; float: right; } 
--></style> </head><body> <div id=\"titles\"> <h1>ERROR</h1> <h2>The requested
URL could not be retrieved</h2> </div> <hr>  <div id=\"content\"> <p>The
following error was encountered while trying to retrieve the URL: <a
href=\"http://0.1.2.3/charm-info?\">http://0.1.2.3/charm-info?</a></p> 
<blockquote id=\"error\"> <p><b>Access Denied.</b></p> </blockquote>  <p>Access
control configuration prevents your request from being allowed at this time. 
Please contact your service provider if you feel this is incorrect.</p>  <p>Your
cache administrator is <a href=\"mailto:webmaster%W\">webmaster</a>.</p> <br>
</div>  <hr> <div id=\"footer\"> <p>Generated Thu, 03 Apr 2014 00:13:35 GMT by
batuan.canonical.com (squid/2.7.STABLE7)</p> <!-- ERR_ACCESS_DENIED --> </div>
</body></html> "

dave_cheney.net

On 2014/04/03 01:46:44, waigani wrote: > Please take a look. Very close. Maybe we don't ...

10 years, 1 month ago (2014-04-03 02:10:41 UTC) #8

waigani

On 2014/04/03 02:10:41, dfc wrote: > On 2014/04/03 01:46:44, waigani wrote: > > Please take ...

10 years, 1 month ago (2014-04-03 03:13:19 UTC) #9

dave_cheney.net

On 2014/04/03 03:13:35, waigani wrote: > Please take a look. LGTM. Thank you

10 years, 1 month ago (2014-04-03 03:28:11 UTC) #11

axw

Please fix the Close(), and consider whether we should have logging. Otherwise LGTM. https://codereview.appspot.com/83310044/diff/80001/charm/repo.go File ...

10 years, 1 month ago (2014-04-03 03:28:18 UTC) #12

dave_cheney.net

https://codereview.appspot.com/83310044/diff/100001/charm/repo.go File charm/repo.go (right): https://codereview.appspot.com/83310044/diff/100001/charm/repo.go#newcode188 charm/repo.go:188: bodyString := string(body) not needed https://codereview.appspot.com/83310044/diff/100001/charm/repo.go#newcode189 charm/repo.go:189: log.Debugf("%v Response ...

10 years, 1 month ago (2014-04-03 03:51:45 UTC) #14

Please take a look.

Expand All Messages | Collapse All Messages