Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 8307045: listen on multiple addresses (and families) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by Giampaolo Rodola
Modified:
5 years, 6 months ago
Visibility:
Public.

Description

listen on multiple addresses (and families)

Patch Set 1 #

Total comments: 4

Patch Set 2 : adds reuse_address option; provide a clearer message on EADDRINUSE #

Total comments: 3

Patch Set 3 : use "*" after port=None; raise the correct errno in case of error on bind() #

Patch Set 4 : update AbstractEventLoop.start_serving signature; move docstring #

Total comments: 1

Patch Set 5 : update example scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -40 lines) Patch
M examples/mpsrv.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M examples/wssrv.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M srv.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tests/events_test.py View 1 2 3 4 5 chunks +31 lines, -5 lines 0 comments Download
M tulip/base_events.py View 1 2 3 4 2 chunks +48 lines, -27 lines 0 comments Download
M tulip/events.py View 1 2 3 4 2 chunks +31 lines, -1 line 0 comments Download
M tulip/test_utils.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12
Andrew Svetlov
Some comments https://codereview.appspot.com/8307045/diff/1/tulip/base_events.py File tulip/base_events.py (right): https://codereview.appspot.com/8307045/diff/1/tulip/base_events.py#newcode455 tulip/base_events.py:455: reuse_addr = os.name == 'posix' and sys.platform ...
6 years, 4 months ago (2013-04-03 18:49:51 UTC) #1
Giampaolo Rodola
https://codereview.appspot.com/8307045/diff/1/tulip/base_events.py File tulip/base_events.py (right): https://codereview.appspot.com/8307045/diff/1/tulip/base_events.py#newcode455 tulip/base_events.py:455: reuse_addr = os.name == 'posix' and sys.platform != 'cygwin' ...
6 years, 4 months ago (2013-04-03 20:31:05 UTC) #2
Giampaolo Rodola
I need to post an updated patch. Can I somehow update this ticket or shall ...
6 years, 4 months ago (2013-04-03 20:34:36 UTC) #3
Nikolay Kim
On 2013/04/03 20:34:36, g.rodola wrote: > I need to post an updated patch. > Can ...
6 years, 4 months ago (2013-04-03 20:41:31 UTC) #4
Giampaolo Rodola
Thanks, done. 2013/4/3 <fafhrd91@gmail.com>: > On 2013/04/03 20:34:36, g.rodola wrote: >> >> I need to ...
6 years, 4 months ago (2013-04-03 20:45:10 UTC) #5
Nikolay Kim
https://codereview.appspot.com/8307045/diff/2002/tests/events_test.py File tests/events_test.py (right): https://codereview.appspot.com/8307045/diff/2002/tests/events_test.py#newcode796 tests/events_test.py:796: # This is quite mysterious, but necessary. this is ...
6 years, 4 months ago (2013-04-03 20:55:44 UTC) #6
gvrpython
Using the upload.py script, it's simple: upload.py -i 8307045 On Wed, Apr 3, 2013 at ...
6 years, 4 months ago (2013-04-03 21:44:29 UTC) #7
Giampaolo Rodola
https://codereview.appspot.com/8307045/diff/2002/tulip/base_events.py File tulip/base_events.py (right): https://codereview.appspot.com/8307045/diff/2002/tulip/base_events.py#newcode469 tulip/base_events.py:469: type=socket.SOCK_STREAM, proto=0, flags=flags) On 2013/04/03 20:55:44, Nikolay Kim wrote: ...
6 years, 4 months ago (2013-04-03 22:55:17 UTC) #8
Nikolay Kim
On 2013/04/03 22:55:17, g.rodola wrote: > https://codereview.appspot.com/8307045/diff/2002/tulip/base_events.py > File tulip/base_events.py (right): > > https://codereview.appspot.com/8307045/diff/2002/tulip/base_events.py#newcode469 > ...
6 years, 4 months ago (2013-04-03 23:02:38 UTC) #9
Giampaolo Rodola
On 2013/04/03 23:02:38, Nikolay Kim wrote: > On 2013/04/03 22:55:17, g.rodola wrote: > > https://codereview.appspot.com/8307045/diff/2002/tulip/base_events.py ...
6 years, 4 months ago (2013-04-03 23:34:54 UTC) #10
Nikolay Kim
You should change AbstractEventLoop.start_serving signature to reflect new api. I'd move doc string as well. ...
6 years, 4 months ago (2013-04-03 23:53:10 UTC) #11
GvR
6 years, 4 months ago (2013-04-23 03:29:55 UTC) #12
There's a start_serving() call in srv.py that will break with this change. 
Possibly other calls in other examples recently added too.  Please fix those. 
Also one comment about docstring markup.

https://codereview.appspot.com/8307045/diff/22001/tulip/events.py
File tulip/events.py (right):

https://codereview.appspot.com/8307045/diff/22001/tulip/events.py#newcode188
tulip/events.py:188: """Creates a TCP server bound to *host* and *port* and
return
Please don't use markup like *host* to refer to the arguments.  It sounds a bit
like *shouting* to my ears.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b