Issue 8270045: Use precise instead of the client machine series.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8270045: Use precise instead of the client machine series.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by thumper

Modified:
11 years, 10 months ago

Reviewers:
mp+156719, dave, rog

Visibility:
Public.

Description

Use precise instead of the client machine series. version.Current now refers to precise for the Series rather than trying to determine this from the client's machine. https://code.launchpad.net/~thumper/juju-core/use-precise/+merge/156719 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -17 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	version/current_test.go	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	version/version.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2013/04/02 23:17:21, thumper wrote: > Please take a look. LGTM. Thank you.

11 years, 10 months ago (2013-04-03 05:48:51 UTC) #2

rog

11 years, 10 months ago (2013-04-03 08:02:41 UTC) #3

NOT LGTM.

the whole point of version.Current is so that an agent can report the version
number and series of the current machine. this change loses that point.

there are better solutions to the problem that have been encountered recently.
let's have a chat about them soon.

Expand All Messages | Collapse All Messages