Issue 82660043: Compatibility changes and being a grammar nazi.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 82660043: Compatibility changes and being a grammar nazi. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by adamsh

Modified:
10 years, 1 month ago

Reviewers:
Jordi, amoser, scudette

CC:
rekall-dev_googlegroups.com

Base URL:
https://code.google.com/p/rekall/@master

Visibility:
Public.

More Reviews

Description

Compatibility changes and being a grammar nazi. - Renamed Windows PMEM certificate file for compatibility reasons. - s/principle/principal/ in Windows pmem build tool. BUG= R=amoser@google.com Committed: c7c8cf3

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -39 lines)			Patch
M	tools/windows/winpmem/build_winpmem.py	View	5 chunks	+10 lines, -10 lines	0 comments	Download
D	tools/windows/winpmem/certs/DigiCert High Assurance EV Root CA.crt	View	1 chunk	+0 lines, -30 lines	0 comments	Download
A +	tools/windows/winpmem/certs/DigiCert_High_Assurance_EV_Root_CA.crt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adamsh

10 years, 1 month ago (2014-03-31 13:51:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rc7c8cf3 (presubmit successful).

Expand All Messages | Collapse All Messages