Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 82530043: state/api: Add Provisioner.Networks API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by dimitern
Modified:
10 years, 1 month ago
Reviewers:
mp+213433, gz, fwereade
Visibility:
Public.

Description

state/api: Add Provisioner.Networks API In order for the provisioner to know whether a machine has networks set (coming from the service that needs a unit to be assigned to a new machine), a new Provisioner.Networks() API method is added to both server-side and client-side Provisioner API. In the following branches the provisioner will use this to check if it's possible to provision a machine with specified networks and actually pass them through at StartInstance() time. https://code.launchpad.net/~dimitern/juju-core/379-api-provisioner-networks/+merge/213433 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api: Add Provisioner.Networks API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/params/internal.go View 1 chunk +12 lines, -0 lines 0 comments Download
M state/api/provisioner/machine.go View 1 chunk +19 lines, -0 lines 0 comments Download
M state/api/provisioner/provisioner_test.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
M state/apiserver/provisioner/provisioner.go View 1 chunk +25 lines, -0 lines 0 comments Download
M state/apiserver/provisioner/provisioner_test.go View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dimitern
Please take a look.
10 years, 1 month ago (2014-03-31 11:08:04 UTC) #1
fwereade
LGTM
10 years, 1 month ago (2014-03-31 11:53:05 UTC) #2
gz
LGTM.
10 years, 1 month ago (2014-03-31 11:59:58 UTC) #3
dimitern
10 years, 1 month ago (2014-04-02 10:03:13 UTC) #4
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b