Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(546)

Issue 8249044: Update adsense samples to use apliclient.sample_tools. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by jcgregorio_google
Modified:
12 years, 1 month ago
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Description

Update adsense samples to use apliclient.sample_tools.

Patch Set 1 #

Patch Set 2 : remove file #

Patch Set 3 : 80 chars #

Total comments: 8

Patch Set 4 : rewording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -296 lines) Patch
M samples/adsense/generate_report.py View 1 2 2 chunks +18 lines, -17 lines 0 comments Download
M samples/adsense/generate_report_with_paging.py View 1 2 2 chunks +14 lines, -14 lines 0 comments Download
M samples/adsense/get_account_tree.py View 2 chunks +14 lines, -13 lines 0 comments Download
M samples/adsense/get_all_accounts.py View 2 chunks +7 lines, -6 lines 0 comments Download
M samples/adsense/get_all_ad_clients.py View 2 chunks +7 lines, -6 lines 0 comments Download
M samples/adsense/get_all_ad_clients_for_account.py View 2 chunks +14 lines, -13 lines 0 comments Download
M samples/adsense/get_all_ad_units.py View 1 2 2 chunks +15 lines, -15 lines 0 comments Download
M samples/adsense/get_all_ad_units_for_custom_channel.py View 1 2 2 chunks +22 lines, -27 lines 0 comments Download
M samples/adsense/get_all_custom_channels.py View 1 2 3 2 chunks +15 lines, -15 lines 0 comments Download
M samples/adsense/get_all_custom_channels_for_ad_unit.py View 1 2 3 2 chunks +26 lines, -26 lines 0 comments Download
M samples/adsense/get_all_saved_ad_styles.py View 2 chunks +7 lines, -6 lines 0 comments Download
M samples/adsense/get_all_saved_reports.py View 2 chunks +7 lines, -6 lines 0 comments Download
M samples/adsense/get_all_url_channels.py View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
R samples/adsense/sample_utils.py View 1 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 9
dhermes
You and Sergio good on this review or do you need my eyes too?
12 years, 3 months ago (2013-04-05 17:24:59 UTC) #1
jcgregorio_google
No, I added you so you could see apiclient.sample_tools in action. On Fri, Apr 5, ...
12 years, 3 months ago (2013-04-05 17:26:52 UTC) #2
jcgregorio_google
12 years, 3 months ago (2013-04-05 17:55:28 UTC) #3
jcgregorio_google
12 years, 3 months ago (2013-04-05 18:05:20 UTC) #4
dhermes
General changes look good. I'll leave it to Sergio for the final OK https://codereview.appspot.com/8249044/diff/5001/samples/adsense/generate_report.py File ...
12 years, 3 months ago (2013-04-05 18:36:02 UTC) #5
jcgregorio_google
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/generate_report.py File samples/adsense/generate_report.py (right): https://codereview.appspot.com/8249044/diff/5001/samples/adsense/generate_report.py#newcode35 samples/adsense/generate_report.py:35: help='The ID of the ad client for which to ...
12 years, 3 months ago (2013-04-05 18:39:08 UTC) #6
jalc
Minor comments, LGTM. https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_custom_channels.py File samples/adsense/get_all_custom_channels.py (right): https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_custom_channels.py#newcode35 samples/adsense/get_all_custom_channels.py:35: help='The ID of the ad client ...
12 years, 2 months ago (2013-04-26 17:09:57 UTC) #7
jcgregorio_google
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_custom_channels.py File samples/adsense/get_all_custom_channels.py (right): https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_custom_channels.py#newcode35 samples/adsense/get_all_custom_channels.py:35: help='The ID of the ad client for which to ...
12 years, 1 month ago (2013-05-16 20:54:51 UTC) #8
jcgregorio_google
12 years, 1 month ago (2013-05-20 20:06:10 UTC) #9
Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=f40bfee6a4...

On 2013/05/16 20:54:51, jcgregorio_google wrote:
>
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_cust...
> File samples/adsense/get_all_custom_channels.py (right):
> 
>
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_cust...
> samples/adsense/get_all_custom_channels.py:35: help='The ID of the ad client
for
> which to generate a report')
> On 2013/04/26 17:09:57, jalc wrote:
> > The ad client ID for which to get custom channels
> 
> Done.
> 
>
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_cust...
> File samples/adsense/get_all_custom_channels_for_ad_unit.py (right):
> 
>
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_cust...
> samples/adsense/get_all_custom_channels_for_ad_unit.py:40: help='The ID of the
> ad client for which to generate a report')
> On 2013/04/26 17:09:57, jalc wrote:
> > "The ID of the ad client with the specified ad unit"
> > 
> > It makes more sense to have the account before the ad client.
> 
> Done.
> 
>
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_url_...
> File samples/adsense/get_all_url_channels.py (right):
> 
>
https://codereview.appspot.com/8249044/diff/5001/samples/adsense/get_all_url_...
> samples/adsense/get_all_url_channels.py:37: help='The ID of the ad client for
> which to generate a report')
> On 2013/04/26 17:09:57, jalc wrote:
> > The ad client ID for which to get URL channels
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b