Remove obsolete Public/PrivateAddress methods

Remove obsolete Public/PrivateAddress methods

The PublicAddress() and PrivateAddress() methods
on environs.EnvironProvider are no longer needed
since units now get their addresses from their
assigned machine, and these addresses are
updated by the instanc poller. 

Extra logic was required to allow the existing
machineAddresses method to be able to handle
subordinate units.

This work allows the Joyent provider to be 
enabled. Smoke tested by hand on Joyent, local,
EC2, HP CLoud and Azure: bootstrap environment,
deploy a unit or two and check status. For
Joyent, do a little more testing and ensure
wordpress works.

https://code.launchpad.net/~wallyworld/juju-core/remove-provider-addr-methods/+merge/213404

(do not edit description out of merge proposal)

[wallyworld, 2014-03-31 05:23:26]

Please take a look.

[axw, 2014-03-31 05:34:47]

This makes me very happy. LGTM with suggested simplification.

It would be nice to drop Set{Public,Private}Address from
state/api/uniter/unit.go, but that'll probably break a bunch of tests. Can you
please create a bug against 1.20 (or 1.22 if this doesn't make 1.18) to delete
both client and server side code?

https://codereview.appspot.com/82470043/diff/1/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/82470043/diff/1/state/unit.go#newcode502
state/unit.go:502: // If a unit is a subordinate we get the address of the
machine associated
All of this can be replaced with
    id, err := u.AssignedMachineId()
    if err != nil {
        unitLogger.Errorf("unit %v cannot get assigned machine: %v", u, err)
        return nil
    }

(it does the right thing for principals/subordinates already)

[wallyworld, 2014-03-31 07:13:10]

There's already a bug raised for this: lp:1221798

https://codereview.appspot.com/82470043/diff/1/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/82470043/diff/1/state/unit.go#newcode502
state/unit.go:502: // If a unit is a subordinate we get the address of the
machine associated
On 2014/03/31 05:34:48, axw wrote:
> All of this can be replaced with
>     id, err := u.AssignedMachineId()
>     if err != nil {
>         unitLogger.Errorf("unit %v cannot get assigned machine: %v", u, err)
>         return nil
>     }
> 
> (it does the right thing for principals/subordinates already)

Done.

[wallyworld, 2014-03-31 07:15:28]

Please take a look.

[fwereade, 2014-03-31 07:26:45]

w00t!