Issue 824051: code review 824051: Added strings.FieldsFunc, a generalization of strings.F...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 824051: code review 824051: Added strings.FieldsFunc, a generalization of strings.F... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by Kyle C

Modified:
14 years, 11 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

Added strings.FieldsFunc, a generalization of strings.Fields in style of the strings.Trim*Func functions.

Patch Set 2 : code review 824051: Added strings.FieldsFunc, a generalization of strings.F... #

Total comments: 1

Patch Set 3 : code review 824051: Added strings.FieldsFunc, a generalization of strings.F... #

Total comments: 1

Patch Set 4 : code review 824051: Added strings.FieldsFunc, a generalization of strings.F... #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	src/pkg/strings/strings.go	View	1 2 3	2 chunks	+9 lines, -2 lines	0 comments	Download
	M	src/pkg/strings/strings_test.go	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Kyle C

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-04-19 21:46:22 UTC) #1

works for me but you should provide a test. http://codereview.appspot.com/824051/diff/2001/3001 File src/pkg/strings/strings.go (right): http://codereview.appspot.com/824051/diff/2001/3001#newcode212 src/pkg/strings/strings.go:212: ...

14 years, 11 months ago (2010-04-19 22:47:04 UTC) #2

Kyle C

Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 11 months ago (2010-04-19 23:12:13 UTC) #3

code is good but please tweak the comment http://codereview.appspot.com/824051/diff/7001/1002 File src/pkg/strings/strings.go (right): http://codereview.appspot.com/824051/diff/7001/1002#newcode179 src/pkg/strings/strings.go:179: // ...

14 years, 11 months ago (2010-04-19 23:15:57 UTC) #4

Kyle C

Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 11 months ago (2010-04-19 23:35:10 UTC) #5

14 years, 11 months ago (2010-04-19 23:36:53 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=ad21a808b3c1 ***

Added strings.FieldsFunc, a generalization of strings.Fields in style of the
strings.Trim*Func functions.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/824051

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages