Consolidate all Proxy url params to ProxyUri

The latest rewriters refactoring introduce new ProyUri class to handle proxy paramaters.
Some parameters like image resiaze, fallback url, mime type etc, are not captured by it, and specifically handled by the proxy servlet.

The change here add all the params to ProxyUri, and eliminate the usage of the original url by the proxy servlet/handler.

It also make the proxy Uri responsible for the conversion to url parameter (it already did the parsing in the constructor)

The change is not complete, I send it out for preliminary/design review. Update is coming soon.
TODO:
- Complete tests
- Apply same rules for concat

[zhoresh, 2010-03-29 23:48:42]

Attahced include added tes, clean up, and concat (which didn't really needed
much)

[johnfargo, 2010-03-30 06:19:35]

The strategy generally looks good, though I admit the preponderance of query
params starts calling into question a more general Map-based strategy. For the
moment though, looks good. Thoughts?

http://codereview.appspot.com/823042/diff/9001/10005
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java
(right):

http://codereview.appspot.com/823042/diff/9001/10005#newcode90
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:90:
public ProxyUri setFallbackUrl(String url) {
unused?

[zhoresh, 2010-03-30 16:04:56]

I started implementing using a map based. but it didn't look right to me
with some parameters saved directly and some as map.
I had to do more code to keep parameters in sync. Also the current code try
to validate each param, so keeping direct value seems appropriate.

But now that you mention it, I might still want to add a map, for what we
discussed as a service that support experimental params.


On Mon, Mar 29, 2010 at 11:19 PM, <johnfargo@gmail.com> wrote:

> The strategy generally looks good, though I admit the preponderance of
> query params starts calling into question a more general Map-based
> strategy. For the moment though, looks good. Thoughts?
>
>
> http://codereview.appspot.com/823042/diff/9001/10005
> File
>
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java
> (right):
>
> http://codereview.appspot.com/823042/diff/9001/10005#newcode90
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:90:
> public ProxyUri setFallbackUrl(String url) {
> unused?


All the set function are not really used at this point. They will be needed
for a proxy service that has more global API then just url.


>
>
> http://codereview.appspot.com/823042/show
>

[johnfargo, 2010-03-30 19:09:38]

On Tue, Mar 30, 2010 at 9:04 AM, Ziv Horesh <zhoresh@gmail.com> wrote:

> I started implementing using a map based. but it didn't look right to me
> with some parameters saved directly and some as map.
> I had to do more code to keep parameters in sync. Also the current code try
> to validate each param, so keeping direct value seems appropriate.
>

Seems like a reasonable argument. I'll remove the setter for now and commit.

Cheers,
John


>
> But now that you mention it, I might still want to add a map, for what we
> discussed as a service that support experimental params.
>
>
> On Mon, Mar 29, 2010 at 11:19 PM, <johnfargo@gmail.com> wrote:
>
>> The strategy generally looks good, though I admit the preponderance of
>> query params starts calling into question a more general Map-based
>> strategy. For the moment though, looks good. Thoughts?
>>
>>
>> http://codereview.appspot.com/823042/diff/9001/10005
>> File
>>
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java
>> (right):
>>
>> http://codereview.appspot.com/823042/diff/9001/10005#newcode90
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java:90:
>> public ProxyUri setFallbackUrl(String url) {
>> unused?
>
>
> All the set function are not really used at this point. They will be needed
> for a proxy service that has more global API then just url.
>
>
>>
>>
>> http://codereview.appspot.com/823042/show
>>
>
>