Issue 82050043: Initial joyent provider

Issue 82050043: Initial joyent provider (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by wallyworld

Modified:
10 years, 12 months ago

Reviewers:
thumper, mp+213348

Visibility:
Public.

Description

Initial joyent provider This branch takes the work done by Daniele and fixes some issues and updates some tests such that the Joyent provider can bootstrap an environemtn and deploy a charm. There's still a couple of unimplemented methods on the provider (PublicAddress, PrivateAddress) but we need to get this work merged so development can continue iteratively. https://code.launchpad.net/~wallyworld/juju-core/joyent-provider-instance/+merge/213348 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Initial joyent provider #

Patch Set 3 : Initial joyent provider #

Total comments: 4

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2366 lines, -474 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dependencies.tsv	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	provider/all/all.go	View		1 chunk	+1 line, -1 line	2 comments	Download
M	provider/joyent/config.go	View		8 chunks	+164 lines, -99 lines	2 comments	Download
M	provider/joyent/config_test.go	View	1	8 chunks	+182 lines, -124 lines	0 comments	Download
M	provider/joyent/environ.go	View	1 2	3 chunks	+95 lines, -40 lines	0 comments	Download
M	provider/joyent/environ_firewall.go	View	1	1 chunk	+123 lines, -21 lines	0 comments	Download
M	provider/joyent/environ_instance.go	View	1	1 chunk	+250 lines, -34 lines	0 comments	Download
M	provider/joyent/export_test.go	View	1	1 chunk	+189 lines, -1 line	0 comments	Download
M	provider/joyent/instance.go	View	1	1 chunk	+87 lines, -34 lines	0 comments	Download
M	provider/joyent/instance_firewall.go	View	1	1 chunk	+97 lines, -18 lines	0 comments	Download
M	provider/joyent/joyent_test.go	View	1	1 chunk	+98 lines, -17 lines	0 comments	Download
A	provider/joyent/live_test.go	View		1 chunk	+94 lines, -0 lines	0 comments	Download
A	provider/joyent/local_test.go	View	1	1 chunk	+423 lines, -0 lines	0 comments	Download
M	provider/joyent/provider.go	View	1	3 chunks	+73 lines, -49 lines	0 comments	Download
A	provider/joyent/provider_test.go	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	provider/joyent/storage.go	View	1	1 chunk	+264 lines, -36 lines	0 comments	Download
A	provider/joyent/storage_test.go	View	1	1 chunk	+199 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

thumper

LGTM with it disabled for now https://codereview.appspot.com/82050043/diff/40001/provider/all/all.go File provider/all/all.go (right): https://codereview.appspot.com/82050043/diff/40001/provider/all/all.go#newcode10 provider/all/all.go:10: _ "launchpad.net/juju-core/provider/joyent" Let's ...

11 years ago (2014-03-31 02:42:39 UTC) #4

wallyworld

11 years ago (2014-03-31 03:20:55 UTC) #5

https://codereview.appspot.com/82050043/diff/40001/provider/all/all.go
File provider/all/all.go (right):

https://codereview.appspot.com/82050043/diff/40001/provider/all/all.go#newcode10
provider/all/all.go:10: _ "launchpad.net/juju-core/provider/joyent"
On 2014/03/31 02:42:39, thumper wrote:
> Let's land it disabled for the 1.18 branch plz

Disabled till the next branch lands which will make the provider work

https://codereview.appspot.com/82050043/diff/40001/provider/joyent/config.go
File provider/joyent/config.go (right):

https://codereview.appspot.com/82050043/diff/40001/provider/joyent/config.go#...
provider/joyent/config.go:275: if strings.HasPrefix(parsedUrl.Host, "localhost")
|| strings.HasPrefix(parsedUrl.Host, "127.0.0.1") {
On 2014/03/31 02:42:39, thumper wrote:
> Perhaps this should just be "127.0.0." ?
> 
> As loopback is 127.0.0.0/8 RFC 1122

Done.

Expand All Messages | Collapse All Messages