Issue 820045: code review 820045: gc benchmark: Update package list

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 820045: code review 820045: gc benchmark: Update package list (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by eds

Modified:
14 years, 11 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

gc benchmark: Update package list Some old packages on the list were preventing this benchmark from working.

Patch Set 2 : code review 820045: gc benchmark: Update package list #

Patch Set 3 : code review 820045: gc benchmark: Update package list #

Total comments: 1

Patch Set 4 : code review 820045: gc benchmark: Update package list #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	test/garbage/parser.go	View	1 2 3	6 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

eds

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 11 months ago (2010-04-18 14:02:15 UTC) #1

http://codereview.appspot.com/820045/diff/6001/7001 File test/garbage/parser.go (right): http://codereview.appspot.com/820045/diff/6001/7001#newcode162 test/garbage/parser.go:162: "exp/parser", i think this one is gone too

14 years, 11 months ago (2010-04-19 20:56:15 UTC) #2

eds

Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 11 months ago (2010-04-19 22:39:12 UTC) #3

14 years, 11 months ago (2010-04-19 22:41:44 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=27b0d9490cdb ***

gc benchmark: Update package list

Some old packages on the list were preventing this benchmark from working.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/820045

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages