Issue 81850043: api/agent: StateServingInfo API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81850043: api/agent: StateServingInfo API

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by mfoord

Modified:
10 years, 1 month ago

Reviewers:
mp+213125, rog

Visibility:
Public.

Description

api/agent: StateServingInfo API API for new state servers to fetch state serving info. https://code.launchpad.net/~mfoord/juju-core/stateservinginfo-api/+merge/213125 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/agent/machine_test.go	View	1 chunk	+28 lines, -0 lines	1 comment	Download
M	state/api/agent/state.go	View	1 chunk	+9 lines, -0 lines	1 comment	Download
M	state/apiserver/agent/agent.go	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rog

10 years, 1 month ago (2014-03-28 11:36:15 UTC) #2

LGTM

https://codereview.appspot.com/81850043/diff/1/state/api/agent/machine_test.go
File state/api/agent/machine_test.go (right):

https://codereview.appspot.com/81850043/diff/1/state/api/agent/machine_test.g...
state/api/agent/machine_test.go:37: var _ = gc.Suite(&servingInfoSuite{})
i'd declare the suite and its methods contiguously, rather than intermingling.

https://codereview.appspot.com/81850043/diff/1/state/api/agent/state.go
File state/api/agent/state.go (right):

https://codereview.appspot.com/81850043/diff/1/state/api/agent/state.go#newco...
state/api/agent/state.go:46: if err != nil {
this if statement is redundant.

Expand All Messages | Collapse All Messages