Issue 81770044: Send panel input purpose.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81770044: Send panel input purpose. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by fujiwara

Modified:
10 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Send panel input purpose. gnome-shell gets input purpose so that disables IME with password mode.

Patch Set 2 : Do not to emit ContentType in bus_panel_proxy_focus_in(). #

Total comments: 2

Patch Set 3 : Updated with message #2. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -68 lines)			Patch
M	bus/inputcontext.h	View	1 2	2 chunks	+100 lines, -58 lines	0 comments	Download
M	bus/inputcontext.c	View		2 chunks	+14 lines, -2 lines	0 comments	Download
M	bus/panelproxy.h	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	bus/panelproxy.c	View	1	3 chunks	+20 lines, -2 lines	0 comments	Download
M	src/ibuspanelservice.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/ibuspanelservice.c	View		8 chunks	+54 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/81770044/diff/20001/bus/inputcontext.h File bus/inputcontext.h (right): https://codereview.appspot.com/81770044/diff/20001/bus/inputcontext.h#newcode218 bus/inputcontext.h:218: guint *hints); Would like to reformat this file ...

10 years, 2 months ago (2014-04-02 16:14:49 UTC) #2

fujiwara

10 years, 2 months ago (2014-04-03 03:17:49 UTC) #3

https://codereview.appspot.com/81770044/diff/20001/bus/inputcontext.h
File bus/inputcontext.h (right):

https://codereview.appspot.com/81770044/diff/20001/bus/inputcontext.h#newcode218
bus/inputcontext.h:218: guint           *hints);
On 2014/04/02 16:14:50, Peng wrote:
> Would like to reformat this file to fit in 80 chars?

Done.

Expand All Messages | Collapse All Messages