Issue 81690043: Issue 1758: instructorFeedbackComment: Comment feature does not work on Firefox 27/28

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81690043: Issue 1758: instructorFeedbackComment: Comment feature does not work on Firefox 27/28

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by lwl1991

Modified:
10 years, 5 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1758: instructorFeedbackComment: Comment feature does not work on Firefox 27/28

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -106 lines)			Patch
M	src/main/webapp/jsp/instructorFeedbackResultsByRecipient.jsp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/InstructorFeedbackResultsPage.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsPageOpen.html	View	26 chunks	+63 lines, -50 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsSortRecipient.html	View	27 chunks	+64 lines, -52 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 5 months ago (2014-03-28 12:24:29 UTC) #1

https://codereview.appspot.com/81690043/diff/1/src/test/resources/pages/instr...
File src/test/resources/pages/instructorFeedbackResultsSortRecipient.html
(right):

https://codereview.appspot.com/81690043/diff/1/src/test/resources/pages/instr...
src/test/resources/pages/instructorFeedbackResultsSortRecipient.html:1115:
V4.18]
This should not be hardcoded. I fixed it before applying the patch.

Expand All Messages | Collapse All Messages