Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(263)

Issue 8166047: Only update needs composited scrolling when necessary.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by vollick
Modified:
12 years, 9 months ago
Base URL:
git://git.webkit.org/WebKit.git@master
Visibility:
Public.

Description

Only update needs composited scrolling when necessary. This CL is an update to Glenn's patch https://bugs.webkit.org/show_bug.cgi?id=109966. As I made fixes to the composite patch, I made pretty significant changes to the 'early-out' code. Please let me know what you think. R=hartmanng@chromium.org,shawnsingh@chromium.org BUG=177714

Patch Set 1 #

Total comments: 7

Patch Set 2 : Move globals to RenderView. #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -79 lines) Patch
A LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html View 1 chunk +169 lines, -0 lines 2 comments Download
A LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change-expected.txt View 1 chunk +39 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html View 1 1 chunk +12 lines, -3 lines 1 comment Download
M Source/WebCore/dom/Document.cpp View 1 2 chunks +6 lines, -0 lines 1 comment Download
M Source/WebCore/rendering/RenderLayer.h View 1 6 chunks +40 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 1 27 chunks +226 lines, -75 lines 6 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.cpp View 1 7 chunks +7 lines, -0 lines 1 comment Download
M Source/WebCore/rendering/RenderView.h View 1 2 chunks +9 lines, -1 line 2 comments Download
M Source/WebCore/rendering/RenderView.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
vollick
I am splitting this composite patch into two pieces (https://codereview.appspot.com/7759045/). This is the first of ...
12 years, 9 months ago (2013-03-30 18:38:06 UTC) #1
shawnsingh
Round 1 of reviewing. I just wanted to get these comments out there sooner, while ...
12 years, 9 months ago (2013-04-01 23:12:50 UTC) #2
hartmanng
Apart from Shawn's comments, I don't think I have much new insight to add, given ...
12 years, 9 months ago (2013-04-02 01:48:47 UTC) #3
jchaffraix
https://codereview.appspot.com/8166047/diff/7001/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html File LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html (right): https://codereview.appspot.com/8166047/diff/7001/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html#newcode127 LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html:127: contentSuccessor.style.display = n ? 'block' : 'none'; I find ...
12 years, 9 months ago (2013-04-03 20:33:06 UTC) #4
vollick
12 years, 9 months ago (2013-04-09 16:33:33 UTC) #5
Thanks for the review! I've posted a response and a new patch here
https://codereview.chromium.org/13913013/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b