Issue 81520043: Fixing the Direct Deals example.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81520043: Fixing the Direct Deals example. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by msaniscalchi

Modified:
11 years, 3 months ago

Reviewers:
Joseph DiLallo, jcgregorio_google

CC:
adx-devrel_google.com

Visibility:
Public.

More Reviews

Description

Fixing the Direct Deals example.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	samples/adexchangebuyer/get_direct_deals.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jcgregorio_google

On 2014/04/08 14:32:54, msaniscalchi wrote: > ping... > > Could you take a look Joe ...

11 years, 3 months ago (2014-04-08 14:33:24 UTC) #4

msaniscalchi

Thanks. I'm not an owner for these client libs, could you publish for me? On ...

11 years, 3 months ago (2014-04-08 14:46:13 UTC) #5

jcgregorio_google

11 years, 3 months ago (2014-04-08 14:49:17 UTC) #6

On 2014/04/08 14:46:13, msaniscalchi wrote:
> Thanks. I'm not an owner for these client libs, could you publish for me?

Done. Committed as
https://code.google.com/p/google-api-python-client/source/detail?r=1f19714de7...

> 
> 
> On Tue, Apr 8, 2014 at 10:33 AM, <mailto:jcgregorio@google.com> wrote:
> 
> > On 2014/04/08 14:32:54, msaniscalchi wrote:
> >
> >> ping...
> >>
> >
> >  Could you take a look Joe (Gregorio)?
> >>
> >
> > LGTM
> >
> > https://codereview.appspot.com/81520043/
> >

Expand All Messages | Collapse All Messages