code review 815041: runtime: more malloc statistics

runtime: more malloc statistics
expvar: default publishings for cmdline, memstats
godoc: import expvar

[rsc, 2010-03-28 20:51:20]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-03-29 17:54:24]

LGTM but please improve some of the commentary

http://codereview.appspot.com/815041/diff/2001/3001
File src/cmd/godoc/main.go (right):

http://codereview.appspot.com/815041/diff/2001/3001#newcode32
src/cmd/godoc/main.go:32: _ "expvar"
what does this do?

http://codereview.appspot.com/815041/diff/2001/3002
File src/pkg/expvar/expvar.go (right):

http://codereview.appspot.com/815041/diff/2001/3002#newcode13
src/pkg/expvar/expvar.go:13: //	memstats  runtime.Memstats
here's where to say all you need is an import

http://codereview.appspot.com/815041/diff/2001/3003
File src/pkg/runtime/extern.go (right):

http://codereview.appspot.com/815041/diff/2001/3003#newcode136
src/pkg/runtime/extern.go:136: type MemStatsType struct {
update to agree with edits in c file

http://codereview.appspot.com/815041/diff/2001/3005
File src/pkg/runtime/malloc.h (right):

http://codereview.appspot.com/815041/diff/2001/3005#newcode161
src/pkg/runtime/malloc.h:161: uintptr sys;	// bytes taken from system
taken from? as in allocated?
you used obtained below; that's a better verb

http://codereview.appspot.com/815041/diff/2001/3005#newcode176
src/pkg/runtime/malloc.h:176: uint64	sys;		// bytes obtained from system
how does this differ from heap_sys?

http://codereview.appspot.com/815041/diff/2001/3005#newcode190
src/pkg/runtime/malloc.h:190: uint64	stacks_sys;
ditto

http://codereview.appspot.com/815041/diff/2001/3005#newcode192
src/pkg/runtime/malloc.h:192: uint64	mspan_sys;
ditto

http://codereview.appspot.com/815041/diff/2001/3005#newcode194
src/pkg/runtime/malloc.h:194: uint64	mcache_sys;
ditto

[rsc, 2010-03-29 18:33:04]

> http://codereview.appspot.com/815041/diff/2001/3005#newcode176
> src/pkg/runtime/malloc.h:176: uint64    sys;            // bytes obtained
> from system
> how does this differ from heap_sys?
>
> http://codereview.appspot.com/815041/diff/2001/3005#newcode190
> src/pkg/runtime/malloc.h:190: uint64    stacks_sys;
> ditto
>
> http://codereview.appspot.com/815041/diff/2001/3005#newcode192
> src/pkg/runtime/malloc.h:192: uint64    mspan_sys;
> ditto
>
> http://codereview.appspot.com/815041/diff/2001/3005#newcode194
> src/pkg/runtime/malloc.h:194: uint64    mcache_sys;
> ditto

having trouble saying this succinctly.
right now i have changed the sys field to

	uint64	sys;		// bytes obtained from system (should be sum of *_sys below)

is that enough?

[r2, 2010-03-29 18:34:23]

yes. i didn't even realize what this comment says was true.

On Mar 29, 2010, at 11:33 AM, Russ Cox wrote:

>> http://codereview.appspot.com/815041/diff/2001/3005#newcode176
>> src/pkg/runtime/malloc.h:176: uint64    sys;            // bytes  
>> obtained
>> from system
>> how does this differ from heap_sys?
>>
>> http://codereview.appspot.com/815041/diff/2001/3005#newcode190
>> src/pkg/runtime/malloc.h:190: uint64    stacks_sys;
>> ditto
>>
>> http://codereview.appspot.com/815041/diff/2001/3005#newcode192
>> src/pkg/runtime/malloc.h:192: uint64    mspan_sys;
>> ditto
>>
>> http://codereview.appspot.com/815041/diff/2001/3005#newcode194
>> src/pkg/runtime/malloc.h:194: uint64    mcache_sys;
>> ditto
>
> having trouble saying this succinctly.
> right now i have changed the sys field to
>
> 	uint64	sys;		// bytes obtained from system (should be sum of *_sys  
> below)
>
> is that enough?

[rsc, 2010-03-29 20:06:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=59b889bdb3fc ***

runtime: more malloc statistics
expvar: default publishings for cmdline, memstats
godoc: import expvar

R=r
CC=golang-dev
http://codereview.appspot.com/815041