Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(666)

Issue 81500043: Issue 548:Remove Calendar Popup and replace with jQuery UI

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by franklingujunchao
Modified:
10 years, 5 months ago
Reviewers:
damith
Visibility:
Public.

Description

Issue 548:Remove Calendar Popup and replace with jQuery UI

Patch Set 1 #

Patch Set 2 : Issue 548:Remove Calendar Popup and replace with jQuery UI #

Total comments: 1

Patch Set 3 : Issue 548:Remove Calendar Popup and replace with jQuery UI #

Patch Set 4 : Issue 548:Remove Calendar Popup and replace with jQuery UI #

Patch Set 5 : Issue 548:Remove Calendar Popup and replace with jQuery UI #

Total comments: 1

Patch Set 6 : Issue 548:Remove Calendar Popup and replace with jQuery UI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+757 lines, -530 lines) Patch
A src/main/webapp/images/arrow.png View Binary file 0 comments Download
A src/main/webapp/images/dark_leather.png View Binary file 0 comments Download
A src/main/webapp/images/darkdenim3.png View Binary file 0 comments Download
A src/main/webapp/js/datepicker.js View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download
M src/main/webapp/js/instructor.js View 6 chunks +7 lines, -8 lines 0 comments Download
M src/main/webapp/js/instructorEvals.js View 1 chunk +1 line, -1 line 0 comments Download
M src/main/webapp/jsp/instructorEvalEdit.jsp View 1 2 3 4 5 3 chunks +8 lines, -8 lines 0 comments Download
M src/main/webapp/jsp/instructorEvals.jsp View 1 2 3 4 5 6 chunks +11 lines, -11 lines 0 comments Download
M src/main/webapp/jsp/instructorFeedbackEdit.jsp View 1 2 3 4 5 5 chunks +4 lines, -5 lines 0 comments Download
M src/main/webapp/jsp/instructorFeedbacks.jsp View 1 2 3 4 5 12 chunks +20 lines, -22 lines 0 comments Download
A src/main/webapp/stylesheets/datepicker.css View 1 chunk +1 line, -0 lines 0 comments Download
M src/test/resources/pages/instructorEvalAddSuccess.html View 1 2 3 4 5 13 chunks +28 lines, -23 lines 0 comments Download
M src/test/resources/pages/instructorEvalByDeadline.html View 1 2 3 4 5 14 chunks +32 lines, -27 lines 0 comments Download
M src/test/resources/pages/instructorEvalById.html View 1 2 3 4 5 14 chunks +33 lines, -26 lines 0 comments Download
M src/test/resources/pages/instructorEvalByName.html View 1 2 3 4 5 13 chunks +31 lines, -24 lines 0 comments Download
M src/test/resources/pages/instructorEvalDeleteSuccessful.html View 1 2 3 4 5 15 chunks +34 lines, -27 lines 0 comments Download
M src/test/resources/pages/instructorEvalEdit.html View 1 2 3 4 5 8 chunks +22 lines, -17 lines 0 comments Download
M src/test/resources/pages/instructorEvalEmptyAll.html View 1 2 3 4 5 13 chunks +31 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorEvalEmptyEval.html View 1 2 3 4 5 14 chunks +30 lines, -24 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackAddSuccess.html View 1 2 3 4 5 6 chunks +17 lines, -9 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackDeleteSuccessful.html View 1 2 3 4 5 12 chunks +30 lines, -25 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditEmpty.html View 1 2 3 4 5 6 chunks +16 lines, -9 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditPublished.html View 1 2 3 4 5 6 chunks +16 lines, -13 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditSuccess.html View 1 2 3 4 5 6 chunks +16 lines, -9 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEmptyAll.html View 1 2 3 4 5 16 chunks +38 lines, -30 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEmptySession.html View 1 2 3 4 5 15 chunks +37 lines, -29 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMcqQuestionAddSuccess.html View 1 2 3 4 5 7 chunks +17 lines, -10 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMcqQuestionEditSuccess.html View 1 2 3 4 5 6 chunks +14 lines, -16 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMsqQuestionAddSuccess.html View 1 2 3 4 5 6 chunks +25 lines, -12 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackMsqQuestionEditSuccess.html View 1 2 3 4 5 6 chunks +9 lines, -5 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackNumScaleQuestionAddSuccess.html View 1 2 3 4 5 6 chunks +25 lines, -12 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackNumScaleQuestionEditSuccess.html View 1 2 3 4 5 6 chunks +9 lines, -5 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackPublishSuccessful.html View 1 2 3 4 5 13 chunks +30 lines, -26 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionAddSuccess.html View 1 2 3 4 5 6 chunks +16 lines, -9 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionEditSuccess.html View 1 2 3 4 5 6 chunks +25 lines, -12 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionEditToTeamToTeam.html View 1 2 3 4 5 8 chunks +19 lines, -21 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionVisibilityOptions.html View 1 2 3 4 5 8 chunks +11 lines, -7 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackUnpublishSuccessful.html View 1 2 3 4 5 14 chunks +31 lines, -23 lines 0 comments Download

Messages

Total messages: 5
damith
https://codereview.appspot.com/81500043/diff/20001/src/main/webapp/stylesheets/datepicker.css File src/main/webapp/stylesheets/datepicker.css (right): https://codereview.appspot.com/81500043/diff/20001/src/main/webapp/stylesheets/datepicker.css#newcode1 src/main/webapp/stylesheets/datepicker.css:1: /* DatePicker Container */ Do we need this file?
10 years, 5 months ago (2014-03-28 10:24:59 UTC) #1
franklingujunchao
Empty? https://codereview.appspot.com/81500043/patch/20001/30012 this file right? Gu Junchao Major in Computer Engineering, National University of Singapore ...
10 years, 5 months ago (2014-03-28 11:15:13 UTC) #2
damith
Yes, in the code review system it shows only one comment line. May be something ...
10 years, 5 months ago (2014-03-28 11:17:43 UTC) #3
damith
It is shown as empty in the 'side by side' view. On Fri, Mar 28, ...
10 years, 5 months ago (2014-03-28 11:18:54 UTC) #4
damith
10 years, 5 months ago (2014-04-01 15:10:30 UTC) #5
https://codereview.appspot.com/81500043/diff/70001/src/main/webapp/jsp/instru...
File src/main/webapp/jsp/instructorEvalEdit.jsp (right):

https://codereview.appspot.com/81500043/diff/70001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorEvalEdit.jsp:26: <script
src="//code.jquery.com/ui/1.10.4/jquery-ui.js"></script>
isn't there a minified version of this?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b