Issue 81440043: state: store and retrieve StateServingInfo doc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81440043: state: store and retrieve StateServingInfo doc

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by mfoord

Modified:
10 years, 1 month ago

Reviewers:
mp+212901, jameinel, rog

Visibility:
Public.

Description

state: store and retrieve StateServingInfo doc Functions to store and retrieve the info needed to run a state server. This doc is created by default when the state is opened for older environments. https://code.launchpad.net/~mfoord/juju-core/state-stateservinginfo/+merge/212901 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : state: store and retrieve StateServingInfo doc #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/params/params.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	state/open.go	View		3 chunks	+17 lines, -0 lines	0 comments	Download
M	state/state.go	View		3 chunks	+27 lines, -1 line	0 comments	Download
M	state/state_test.go	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/81440043/diff/1/state/api/params/params.go File state/api/params/params.go (right): https://codereview.appspot.com/81440043/diff/1/state/api/params/params.go#newcode467 state/api/params/params.go:467: // KeyFile string perhaps have this as a ...

10 years, 1 month ago (2014-03-27 12:37:45 UTC) #2

jameinel

10 years, 1 month ago (2014-03-27 12:52:09 UTC) #4

LGTM. We chatted a bit about names (SharedSecret and PrivateKey), but otherwise
I think its good.

Expand All Messages | Collapse All Messages