Issue 81360048: Issue 1751: Prevent user to join course using the googleId owned by another user in the same course

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81360048: Issue 1751: Prevent user to join course using the googleId owned by another user in the same course

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Oo Theong Siang

Modified:
10 years, 5 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1751: Prevent user to join course using the googleId owned by another user in the same course

Patch Set 2 : Issue 1751: Prevent user to join course using the googleId owned by another user in the same course #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -36 lines)			Patch
M	src/main/java/teammates/common/util/Const.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/logic/core/AccountsLogic.java	View		3 chunks	+67 lines, -33 lines	0 comments	Download
M	src/test/java/teammates/test/cases/logic/AccountsLogicTest.java	View	1	4 chunks	+30 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

damith

https://codereview.appspot.com/81360048/diff/1/src/test/java/teammates/test/cases/logic/AccountsLogicTest.java File src/test/java/teammates/test/cases/logic/AccountsLogicTest.java (right): https://codereview.appspot.com/81360048/diff/1/src/test/java/teammates/test/cases/logic/AccountsLogicTest.java#newcode88 src/test/java/teammates/test/cases/logic/AccountsLogicTest.java:88: ______TS("failure: googleID belongs to a existing student in the ...

10 years, 5 months ago (2014-03-29 03:03:33 UTC) #1

Oo Theong Siang

10 years, 5 months ago (2014-03-29 07:27:40 UTC) #2

https://codereview.appspot.com/81360048/diff/1/src/test/java/teammates/test/c...
File src/test/java/teammates/test/cases/logic/AccountsLogicTest.java (right):

https://codereview.appspot.com/81360048/diff/1/src/test/java/teammates/test/c...
src/test/java/teammates/test/cases/logic/AccountsLogicTest.java:88:
______TS("failure: googleID belongs to a existing student in the course");
On 2014/03/29 03:03:33, damith wrote:
> ...an existing...

Done.

https://codereview.appspot.com/81360048/diff/1/src/test/java/teammates/test/c...
src/test/java/teammates/test/cases/logic/AccountsLogicTest.java:101: }
Yeah, that test case is already included, in line 116.

On 2014/03/29 03:03:33, damith wrote:
> What happens if a person tries to join the course again? i.e. click the same
> join link twice, using the same Google ID. May be we should have a test case
for
> that too?

Expand All Messages | Collapse All Messages