Issue 81330044: instance: make NewAddresses take a vararg

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 81330044: instance: make NewAddresses take a vararg

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by dave

Modified:
10 years, 1 month ago

Reviewers:
mp+213208, rog

Visibility:
Public.

Description

instance: make NewAddresses take a vararg NewAddresses is almost exclusively used in tests, and almost exclusively called with one argument. Making NewAddresses use the vararg form makes the callers of the function easier to read and exposes that most callers would use the singular NewAddress form except they usually pass their return value to SetAddresses which itself is not varargs. Fixing SetAddresses will be the next change. https://code.launchpad.net/~dave-cheney/juju-core/107-new-addresses-take-varargs/+merge/213208 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	instance/address.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	instance/address_test.go	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	state/api/deployer/deployer_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/machiner/machiner_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/provisioner/provisioner_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/megawatcher_internal_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/instancepoller/aggregate_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/peergrouper/mock_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/peergrouper/worker_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rog

10 years, 1 month ago (2014-03-28 07:58:40 UTC) #2

On 2014/03/28 07:32:07, dfc wrote:
> Please take a look.

LGTM++

Expand All Messages | Collapse All Messages