Issue 8102043: Issue 3117: Markup/string identifiers in lyrics cause an error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8102043: Issue 3117: Markup/string identifiers in lyrics cause an error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by dak

Modified:
12 years, 10 months ago

Reviewers:
janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 3117: Markup/string identifiers in lyrics cause an error This fix just addresses markup/string identifiers within music lists. The syntax did already cater for function arguments previously.

Patch Set 1 #

Patch Set 2 : Allow for closed Scheme function calls #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	lily/parser.yy	View	1	1 chunk	+20 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

janek

12 years, 10 months ago (2013-04-02 21:29:57 UTC) #2

As usual with parser patches, i'm not the right person to review them... i think
this one is ok.

Thanks,
Janek

Expand All Messages | Collapse All Messages