Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(337)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 8084043: Mark some parts of library as Beta (HTTP project) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by peleyal
Modified:
12 years, 8 months ago
Reviewers:
yanivi
CC:
ngmiceli
Base URL:
https://code.google.com/p/google-http-java-client/
Visibility:
Public.

Description

API 686: Mark some parts of library as Beta https://code.google.com/p/google-api-java-client/issues/detail?id=686

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : minor #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -335 lines) Patch
M findbugs-exclude.xml View 1 2 1 chunk +2 lines, -10 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/AndroidUtils.java View 1 chunk +3 lines, -3 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/http/AndroidHttp.java View 1 chunk +3 lines, -3 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/http/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonFactory.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonGenerator.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/AndroidJsonParser.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/json/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client-android/src/main/java/com/google/api/client/extensions/android/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client-findbugs/google-http-client-findbugs-test/src/main/java/com/google/api/client/findbugs/test/BetaClass.java View 1 chunk +12 lines, -12 lines 0 comments Download
M google-http-client-findbugs/google-http-client-findbugs-test/src/main/java/com/google/api/client/findbugs/test/BetaClass2.java View 1 chunk +4 lines, -4 lines 0 comments Download
M google-http-client-findbugs/google-http-client-findbugs-test/src/main/java/com/google/api/client/findbugs/test/ClassWithBetaField.java View 1 chunk +10 lines, -10 lines 0 comments Download
M google-http-client-findbugs/google-http-client-findbugs-test/src/main/java/com/google/api/client/findbugs/test/ClassWithBetaMethod.java View 1 chunk +12 lines, -12 lines 0 comments Download
M google-http-client-findbugs/google-http-client-findbugs-test/src/main/java/com/google/api/client/findbugs/test/Test.java View 1 chunk +17 lines, -17 lines 0 comments Download
M google-http-client-findbugs/src/main/java/com/google/api/client/findbugs/BetaDetector.java View 10 chunks +35 lines, -37 lines 0 comments Download
M google-http-client-findbugs/src/main/resources/bugrank.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M google-http-client-findbugs/src/main/resources/findbugs.xml View 1 chunk +5 lines, -5 lines 0 comments Download
M google-http-client-findbugs/src/main/resources/messages.xml View 1 chunk +18 lines, -18 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/ProtoHttpContent.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/http/protobuf/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/ProtoObjectParser.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/ProtocolBuffers.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client-protobuf/src/main/java/com/google/api/client/protobuf/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java View 3 chunks +5 lines, -5 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpTransport.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/xml/AbstractXmlHttpContent.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/xml/XmlHttpContent.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/xml/atom/AtomContent.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/xml/atom/AtomFeedParser.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/xml/atom/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/xml/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/CustomizeJsonParser.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/JsonParser.java View 19 chunks +19 lines, -19 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/rpc2/JsonRpcRequest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/rpc2/package-info.java View 2 chunks +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/webtoken/JsonWebSignature.java View 5 chunks +7 lines, -7 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/webtoken/JsonWebToken.java View 5 chunks +7 lines, -7 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/webtoken/package-info.java View 2 chunks +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/FixedClock.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/HttpTesting.java View 1 chunk +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockHttpContent.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockHttpTransport.java View 5 chunks +5 lines, -5 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockHttpUnsuccessfulResponseHandler.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpRequest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpResponse.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/apache/MockHttpClient.java View 4 chunks +4 lines, -4 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/apache/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/javanet/MockHttpURLConnection.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/javanet/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/json/MockJsonFactory.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/json/MockJsonGenerator.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/json/MockJsonParser.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/json/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/http/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/util/LogRecordingHandler.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/util/MockBackOff.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/util/MockSleeper.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/util/SecurityTestUtils.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/util/TestableByteArrayInputStream.java View 1 chunk +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/util/TestableByteArrayOutputStream.java View 1 chunk +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/testing/util/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/util/BackOffUtils.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/util/Beta.java View 3 chunks +5 lines, -5 lines 1 comment Download
M google-http-client/src/main/java/com/google/api/client/util/PemReader.java View 2 chunks +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/util/SslUtils.java View 4 chunks +4 lines, -4 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/GenericXml.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/Xml.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java View 4 chunks +4 lines, -4 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/XmlObjectParser.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/atom/AbstractAtomFeedParser.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/atom/Atom.java View 2 chunks +3 lines, -3 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/atom/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/xml/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
peleyal
12 years, 8 months ago (2013-03-28 15:18:17 UTC) #1
peleyal
12 years, 8 months ago (2013-03-28 15:18:18 UTC) #2
yanivi
LGTM, except for one that you missed :) https://codereview.appspot.com/8084043/diff/8001/google-http-client/src/main/java/com/google/api/client/util/Beta.java File google-http-client/src/main/java/com/google/api/client/util/Beta.java (right): https://codereview.appspot.com/8084043/diff/8001/google-http-client/src/main/java/com/google/api/client/util/Beta.java#newcode22 google-http-client/src/main/java/com/google/api/client/util/Beta.java:22: * ...
12 years, 8 months ago (2013-03-28 17:30:03 UTC) #3
peleyal
12 years, 8 months ago (2013-03-31 20:53:56 UTC) #4
Message was sent while issue was closed. 
On 2013/03/28 17:30:03, yanivi wrote:
> LGTM, except for one that you missed :)
> 
>
https://codereview.appspot.com/8084043/diff/8001/google-http-client/src/main/...
> File google-http-client/src/main/java/com/google/api/client/util/Beta.java
> (right):
> 
>
https://codereview.appspot.com/8084043/diff/8001/google-http-client/src/main/...
> google-http-client/src/main/java/com/google/api/client/util/Beta.java:22: *
Use
> this annotation to indicate that a public API (class, method or field) is
> experimental.
> experimental -> beta :)

DONE.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b