Fix to issue #424

Fix to issue #424

[RogerHaase, 2014-03-28 21:20:54]

Works for me...

[Thomas.J.Waldmann, 2014-03-30 11:23:29]

https://codereview.appspot.com/80700049/diff/1/MoinMoin/themes/basic/static/c...
File MoinMoin/themes/basic/static/css/basic.css (right):

https://codereview.appspot.com/80700049/diff/1/MoinMoin/themes/basic/static/c...
MoinMoin/themes/basic/static/css/basic.css:753: max-width: 1300px;
can you explain the change?

also, did you edit the css or the .less file?

iirc, the css of the basic theme is generated from LESS files.

[sksaurabhkathpalia, 2014-03-30 17:17:15]

https://codereview.appspot.com/80700049/diff/1/MoinMoin/themes/basic/static/c...
File MoinMoin/themes/basic/static/css/basic.css (right):

https://codereview.appspot.com/80700049/diff/1/MoinMoin/themes/basic/static/c...
MoinMoin/themes/basic/static/css/basic.css:753: max-width: 1300px;
On 2014/03/30 11:23:29, Thomas.J.Waldmann wrote:
> can you explain the change?
> 
> also, did you edit the css or the .less file?
> 
> iirc, the css of the basic theme is generated from LESS files.

Actually previously it is taking the width as fixed but it may exceed the window
size so I have put it to max.
Also in the earlier code there is maximum width defined

[Thomas.J.Waldmann, 2014-05-21 15:34:15]

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/basic/stat...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/basic/stat...
MoinMoin/themes/basic/static/custom-less/basic.less:299: @media (min-width:
768px) {
maybe add some comment about WHY you do that. into the less file.

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/foobar/sta...
File MoinMoin/themes/foobar/static/css/common.css (right):

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/foobar/sta...
MoinMoin/themes/foobar/static/css/common.css:178:
#moin-global-tray{float:left;width:16.666666666666668%;padding:.5%;overflow:hidden}
make sure that you don't create repeating fluctuations like this.

check tools version with roger, so that such stuff stabilizes.

(esp. since it does not seem to have anything to do with your other changes)

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/foobar/sta...
MoinMoin/themes/foobar/static/css/common.css:185:
#moin-local-panel{float:left;width:16.666666666666668%;padding:.5%;margin-left:-1px;border-left:1px
solid #ccc}
... see above.

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/foobar/sta...
MoinMoin/themes/foobar/static/css/common.css:418:
.moin-insertname-action{border:hidden;text-indent:-9000%;padding:0;margin:0
-2px;vertical-align:middle;height:16px;width:16px;overflow:hidden;cursor:pointer;box-shadow:none;background:url("../img/moin-link.png")
no-repeat center center}
can you explain?

[sksaurabhkathpalia, 2014-05-21 15:39:26]

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/basic/stat...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/basic/stat...
MoinMoin/themes/basic/static/custom-less/basic.less:299: @media (min-width:
768px) {
On 2014/05/21 15:34:14, Thomas.J.Waldmann wrote:
> maybe add some comment about WHY you do that. into the less file.

I first made the changes in .less file and then I compiled it using ./m css

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/foobar/sta...
File MoinMoin/themes/foobar/static/css/common.css (right):

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/foobar/sta...
MoinMoin/themes/foobar/static/css/common.css:178:
#moin-global-tray{float:left;width:16.666666666666668%;padding:.5%;overflow:hidden}
On 2014/05/21 15:34:15, Thomas.J.Waldmann wrote:
> make sure that you don't create repeating fluctuations like this.
> 
> check tools version with roger, so that such stuff stabilizes.
> 
> (esp. since it does not seem to have anything to do with your other changes)

Actually this was a bug earlier which I reported also to Roger and later he
corrected that. Now changes in both common.css are not there thats why I asked
you to look at patchset 2 of this cr. That is the final one

[RogerHaase, 2014-06-02 15:27:45]

revert the changes to foobar and modernized common.css, these are side effects
caused by older versions of stylus (now fixed and replaced by other stylus
problems)

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/basic/stat...
File MoinMoin/themes/basic/static/custom-less/basic.less (right):

https://codereview.appspot.com/80700049/diff/60001/MoinMoin/themes/basic/stat...
MoinMoin/themes/basic/static/custom-less/basic.less:299: @media (min-width:
768px) {
On 2014/05/21 15:39:26, sksaurabhkathpalia wrote:
> On 2014/05/21 15:34:14, Thomas.J.Waldmann wrote:
> > maybe add some comment about WHY you do that. into the less file.
> 
> I first made the changes in .less file and then I compiled it using ./m css

add a comment before 299, something like:

// set min-width to prevent search box from floating off window to right