code review 805043: runtime: make type assertion a runtime.Error, the first...

runtime: make type assertion a runtime.Error, the first of many

[rsc, 2010-03-31 22:35:46]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-03-31 22:48:00]

LGTM

http://codereview.appspot.com/805043/diff/2001/3005
File src/pkg/runtime/error.go (right):

http://codereview.appspot.com/805043/diff/2001/3005#newcode10
src/pkg/runtime/error.go:10: RuntimeError() // no-op but uniquely identifies
runtime.Error
s/but/that/

http://codereview.appspot.com/805043/diff/2001/3005#newcode99
src/pkg/runtime/error.go:99: }:
wretched formatting.  how about defining a private interface stringer?

[rsc, 2010-03-31 22:55:13]

*** Submitted as http://code.google.com/p/go/source/detail?r=041923b8667e ***

runtime: make type assertion a runtime.Error, the first of many

R=r
CC=golang-dev
http://codereview.appspot.com/805043