Issue 80470044: Finish the surrounding text implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 80470044: Finish the surrounding text implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by fujiwara

Modified:
11 years, 10 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara, lewtds

Base URL:
git@github.com:ibus/ibus-qt.git@master

Visibility:
Public.

More Reviews

Description

Finish the surrounding text implementation BUG=http://code.google.com/p/ibus/issues/detail?id=1698 TEST=ibus_engine_get_surrounding_text()

Patch Set 2 : Updated with message #3. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -16 lines)			Patch
M	qtim/ibus-input-context.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	qtim/ibus-input-context.cpp	View	1	5 chunks	+40 lines, -4 lines	0 comments	Download
M	src/interfaces/org.freedesktop.IBus.InputContext.xml	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/qibusinputcontext.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	src/qibusinputcontext.cpp	View		3 chunks	+15 lines, -0 lines	0 comments	Download
M	src/qibusinputcontextproxy.h	View		4 chunks	+17 lines, -9 lines	0 comments	Download
M	src/qibusinputcontextproxy.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/qibustypes.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

On 2014/03/26 06:52:37, fujiwara wrote: lgtm with a comment

11 years, 10 months ago (2014-03-26 15:03:59 UTC) #2

Peng

https://codereview.appspot.com/80470044/diff/1/qtim/ibus-input-context.cpp File qtim/ibus-input-context.cpp (right): https://codereview.appspot.com/80470044/diff/1/qtim/ibus-input-context.cpp#newcode171 qtim/ibus-input-context.cpp:171: QString surroundingText = widget->inputMethodQuery (Qt::ImSurroundingText).toString (); 80 chars

11 years, 10 months ago (2014-03-26 15:04:08 UTC) #3

fujiwara

11 years, 10 months ago (2014-03-27 03:15:04 UTC) #4

https://codereview.appspot.com/80470044/diff/1/qtim/ibus-input-context.cpp
File qtim/ibus-input-context.cpp (right):

https://codereview.appspot.com/80470044/diff/1/qtim/ibus-input-context.cpp#ne...
qtim/ibus-input-context.cpp:171: QString surroundingText =
widget->inputMethodQuery (Qt::ImSurroundingText).toString ();
On 2014/03/26 15:04:08, Peng wrote:
> 80 chars

Done.

Expand All Messages | Collapse All Messages