Issue 8038044: Do not attempt to recover from device lost masked by present occluded or display mode changed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8038044: Do not attempt to recover from device lost masked by present occluded or display mode changed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by apatrick1

Modified:
11 years, 1 month ago

Reviewers:
kbr1, nicolas, nicolas%transgaming.com

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Do not attempt to recover from device lost masked by present occluded or display mode changed. The call to IDirect3DDevice9::Present in testDeviceLost sometimes never returns on AMD, resulting in a hang. Also, on AMD, device lost is sometimes never reported at all, even through present occluded or display mode changed. I'll need to do something more robust at the app level. It has something to do with the Chrome GPU process sandbox. These issues only happen when the sandbox is enabled. Cleanup for Surface::recreateAdditionalSwapChains to follow once I determine this gets us back to a stable place. Committed: https://code.google.com/p/angleproject/source/detail?r=2040

Patch Set 1 : #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -28 lines)			Patch
	M	src/libEGL/Display.cpp	View		1 chunk	+1 line, -28 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

apatrick1

Sorry about this nicolas. We have new issues on Dev channel.

11 years, 1 month ago (2013-03-27 00:00:50 UTC) #1

nicolas%transgaming.com

11 years, 1 month ago (2013-03-27 19:09:00 UTC) #3

Too bad it leads to a chain of driver issues. Revert looks fine to me.

Expand All Messages | Collapse All Messages