code review 8011043: net: fix test data corruption in repetitive test runs b...

src/pkg/net/tcp_test.go

 // Copyright 2012 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package net
 
 import (
         "fmt"
         "reflect"
         "runtime"
@@ skipping 153 matching lines @@
         {"tcp6", "[fe80::1]:3", &TCPAddr{IP: ParseIP("fe80::1"), Port: 3, Zone: "name"}, nil},
         {"tcp6", "[fe80::1]:4", &TCPAddr{IP: ParseIP("fe80::1"), Port: 4, Zone: "index"}, nil},
 
         {"", "127.0.0.1:0", &TCPAddr{IP: IPv4(127, 0, 0, 1), Port: 0}, nil}, // Go 1.0 behavior
         {"", "[::1]:0", &TCPAddr{IP: ParseIP("::1"), Port: 0}, nil},         // Go 1.0 behavior
 
         {"http", "127.0.0.1:0", nil, UnknownNetworkError("http")},
 }
 
 func TestResolveTCPAddr(t *testing.T) {
-        for _, tt := range resolveTCPAddrTests {
+        for i, tt := range resolveTCPAddrTests {
                 if tt.addr != nil && (tt.addr.Zone == "name" || tt.addr.Zone == "index") {
                         ifi := loopbackInterface()
                         if ifi == nil {
                                 continue
                         }
-                        i := last(tt.litAddr, ']')
-                        if i > 0 {
+                        j := last(tt.litAddr, ']')
+                        if j > 0 {
                                 switch tt.addr.Zone {
                                 case "name":
-                                        tt.litAddr = tt.litAddr[:i] + "%" + ifi.Name + tt.litAddr[i:]
-                                        tt.addr.Zone = zoneToString(ifi.Index)
+                                        resolveTCPAddrTests[i].litAddr = tt.litAddr[:j] + "%" + ifi.Name + tt.litAddr[j:]
+                                        resolveTCPAddrTests[i].addr.Zone = zoneToString(ifi.Index)
                                 case "index":
                                         index := fmt.Sprintf("%v", ifi.Index)
-                                        tt.litAddr = tt.litAddr[:i] + "%" + index + tt.litAddr[i:]
-                                        tt.addr.Zone = index
+                                        resolveTCPAddrTests[i].litAddr = tt.litAddr[:j] + "%" + index + tt.litAddr[j:]
+                                        resolveTCPAddrTests[i].addr.Zone = index
                                 }
                         }
                 }
-                addr, err := ResolveTCPAddr(tt.net, tt.litAddr)
+                addr, err := ResolveTCPAddr(tt.net, resolveTCPAddrTests[i].litAddr)
                 if err != tt.err {
-                        t.Fatalf("ResolveTCPAddr(%v, %v) failed: %v", tt.net, tt.litAddr, err)
+                        t.Fatalf("ResolveTCPAddr(%v, %v) failed: %v", tt.net, resolveTCPAddrTests[i].litAddr, err)
                 }
-                if !reflect.DeepEqual(addr, tt.addr) {
-                        t.Fatalf("got %#v; expected %#v", addr, tt.addr)
+                if !reflect.DeepEqual(addr, resolveTCPAddrTests[i].addr) {
+                        t.Fatalf("got %#v; expected %#v", addr, resolveTCPAddrTests[i].addr)
                 }
         }
 }
 
 var tcpListenerNameTests = []struct {
         net   string
         laddr *TCPAddr
 }{
         {"tcp4", &TCPAddr{IP: IPv4(127, 0, 0, 1)}},
         {"tcp4", &TCPAddr{}},
@@ skipping 86 matching lines @@
                         t.Fatalf("Conn.Write failed: %v", err)
                 }
                 b := make([]byte, 32)
                 if _, err := c.Read(b); err != nil {
                         t.Fatalf("Conn.Read failed: %v", err)
                 }
 
                 <-done
         }
 }