Pass method by name, not positionally.

Pass method by name, not positionally.

Fixes issue #252.

[dhermes, 2013-03-26 15:38:10]

https://codereview.appspot.com/7987046/diff/1/python2/httplib2/__init__.py
File python2/httplib2/__init__.py (right):

https://codereview.appspot.com/7987046/diff/1/python2/httplib2/__init__.py#ne...
python2/httplib2/__init__.py:1383: (response, content) = self.request(location,
method=redirect_method, body=body, headers = headers, redirections =
redirections - 1)
Can you fix line length and remove the spaces between headers = and redirections
= ?

https://codereview.appspot.com/7987046/diff/1/python2/httplib2/__init__.py#ne...
python2/httplib2/__init__.py:1525: (response, new_content) =
self.request(info['-x-permanent-redirect-url'], method="GET", headers = headers,
redirections = redirections - 1)
Can you fix line length, use single quotes around "GET" and remove the spaces
between headers = and redirections = ?

https://codereview.appspot.com/7987046/diff/1/python3/httplib2/__init__.py
File python3/httplib2/__init__.py (right):

https://codereview.appspot.com/7987046/diff/1/python3/httplib2/__init__.py#ne...
python3/httplib2/__init__.py:1092: (response, content) = self.request(location,
method=redirect_method, body=body, headers = headers, redirections =
redirections - 1)
Can you fix line length and remove the spaces between headers = and redirections
= ?

https://codereview.appspot.com/7987046/diff/1/python3/httplib2/__init__.py#ne...
python3/httplib2/__init__.py:1227: (response, new_content) =
self.request(info['-x-permanent-redirect-url'], method="GET", headers = headers,
redirections = redirections - 1)
Can you fix line length, use single quotes around "GET" and remove the spaces
between headers = and redirections = ?

https://codereview.appspot.com/7987046/diff/1/test/conditional-updates/test.cgi
File test/conditional-updates/test.cgi (right):

https://codereview.appspot.com/7987046/diff/1/test/conditional-updates/test.c...
test/conditional-updates/test.cgi:16: elif method in ["PUT", "DELETE", "PATCH"]:
What's the reason behind this change?

https://codereview.appspot.com/7987046/diff/1/test/vary/no-vary.asis
File test/vary/no-vary.asis (right):

https://codereview.appspot.com/7987046/diff/1/test/vary/no-vary.asis#newcode3
test/vary/no-vary.asis:3: Accept-Encoding: identity
What's the reason behind this change?

[jcgregorio, 2013-03-26 18:07:38]

https://codereview.appspot.com/7987046/diff/1/python2/httplib2/__init__.py
File python2/httplib2/__init__.py (right):

https://codereview.appspot.com/7987046/diff/1/python2/httplib2/__init__.py#ne...
python2/httplib2/__init__.py:1383: (response, content) = self.request(location,
method=redirect_method, body=body, headers = headers, redirections =
redirections - 1)
On 2013/03/26 15:38:10, dhermes wrote:
> Can you fix line length and remove the spaces between headers = and
redirections
> = ?

Done.

https://codereview.appspot.com/7987046/diff/1/python2/httplib2/__init__.py#ne...
python2/httplib2/__init__.py:1525: (response, new_content) =
self.request(info['-x-permanent-redirect-url'], method="GET", headers = headers,
redirections = redirections - 1)
On 2013/03/26 15:38:10, dhermes wrote:
> Can you fix line length, use single quotes around "GET" and remove the spaces
> between headers = and redirections = ?

Done.

https://codereview.appspot.com/7987046/diff/1/python3/httplib2/__init__.py
File python3/httplib2/__init__.py (right):

https://codereview.appspot.com/7987046/diff/1/python3/httplib2/__init__.py#ne...
python3/httplib2/__init__.py:1092: (response, content) = self.request(location,
method=redirect_method, body=body, headers = headers, redirections =
redirections - 1)
On 2013/03/26 15:38:10, dhermes wrote:
> Can you fix line length and remove the spaces between headers = and
redirections
> = ?

Done.

https://codereview.appspot.com/7987046/diff/1/python3/httplib2/__init__.py#ne...
python3/httplib2/__init__.py:1227: (response, new_content) =
self.request(info['-x-permanent-redirect-url'], method="GET", headers = headers,
redirections = redirections - 1)
On 2013/03/26 15:38:10, dhermes wrote:
> Can you fix line length, use single quotes around "GET" and remove the spaces
> between headers = and redirections = ?

Done.

https://codereview.appspot.com/7987046/diff/1/test/conditional-updates/test.cgi
File test/conditional-updates/test.cgi (right):

https://codereview.appspot.com/7987046/diff/1/test/conditional-updates/test.c...
test/conditional-updates/test.cgi:16: elif method in ["PUT", "DELETE", "PATCH"]:
Dropped.

On 2013/03/26 15:38:10, dhermes wrote:
> What's the reason behind this change?

https://codereview.appspot.com/7987046/diff/1/test/vary/no-vary.asis
File test/vary/no-vary.asis (right):

https://codereview.appspot.com/7987046/diff/1/test/vary/no-vary.asis#newcode3
test/vary/no-vary.asis:3: Accept-Encoding: identity
Dropped.

On 2013/03/26 15:38:10, dhermes wrote:
> What's the reason behind this change?

[dhermes, 2013-03-26 18:11:37]

LGTM (Still need to fix one of the lint issues)

https://codereview.appspot.com/7987046/diff/8001/python3/httplib2/__init__.py
File python3/httplib2/__init__.py (right):

https://codereview.appspot.com/7987046/diff/8001/python3/httplib2/__init__.py...
python3/httplib2/__init__.py:1231: headers = headers, redirections =
redirections - 1)
Still a space between headers = and redirections =

[jcgregorio, 2013-03-26 18:15:26]

https://codereview.appspot.com/7987046/diff/8001/python3/httplib2/__init__.py
File python3/httplib2/__init__.py (right):

https://codereview.appspot.com/7987046/diff/8001/python3/httplib2/__init__.py...
python3/httplib2/__init__.py:1231: headers = headers, redirections =
redirections - 1)
On 2013/03/26 18:11:37, dhermes wrote:
> Still a space between headers = and redirections =

Done.

[jcgregorio, 2013-03-26 18:19:19]

Committed in
https://code.google.com/p/httplib2/source/detail?r=93291649202b68c7ebbd8eee08...

On 2013/03/26 18:15:26, jcgregorio wrote:
> https://codereview.appspot.com/7987046/diff/8001/python3/httplib2/__init__.py
> File python3/httplib2/__init__.py (right):
> 
>
https://codereview.appspot.com/7987046/diff/8001/python3/httplib2/__init__.py...
> python3/httplib2/__init__.py:1231: headers = headers, redirections =
> redirections - 1)
> On 2013/03/26 18:11:37, dhermes wrote:
> > Still a space between headers = and redirections =
> 
> Done.