worker/peergrouper: publish instance Ids

worker/peergrouper: publish instance Ids

publishApiServers now takes instanceIds. 
These are not yet published to the environment.

https://code.launchpad.net/~mfoord/juju-core/528-environ-publish-api-servers/+merge/212585

(do not edit description out of merge proposal)

[mfoord, 2014-03-25 16:26:37]

Please take a look.

[gz, 2014-03-25 17:41:19]

Couple of comments.

https://codereview.appspot.com/79820043/diff/2/worker/peergrouper/publish.go
File worker/peergrouper/publish.go (right):

https://codereview.appspot.com/79820043/diff/2/worker/peergrouper/publish.go#...
worker/peergrouper/publish.go:23: return pub.st.SetAPIHostPorts(apiServers)
Need to actually set the instanceIds somewhere here? Or at least a TODO comment.

https://codereview.appspot.com/79820043/diff/2/worker/peergrouper/worker.go
File worker/peergrouper/worker.go (right):

https://codereview.appspot.com/79820043/diff/2/worker/peergrouper/worker.go#n...
worker/peergrouper/worker.go:205: func (w *pgWorker) apiPublishInfo()
([][]instance.HostPort, []instance.Id, error) {
I'd be tempted to bundle this up into a struct { instance.HostPort, instance.Id
} rather than using two slice return values.

[gz, 2014-03-25 17:47:42]

LGTM.

[mfoord, 2014-03-25 17:48:13]

Please take a look.