Issue 79710043: Issue 1711: Introduce joining for instructors: send invitation email instead of requiring google ID…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 79710043: Issue 1711: Introduce joining for instructors: send invitation email instead of requiring google ID…

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Oo Theong Siang

Modified:
10 years, 5 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Issue 1711: Introduce joining for instructors: send invitation email instead of requiring google ID…

Patch Set 1 #

Patch Set 2 : Issue 1711: Introduce joining for instructors: send invitation email instead of requiring google ID… #

Patch Set 3 : Issue 1711: Introduce joining for instructors: send invitation email instead of requiring google ID… #

Patch Set 4 : Issue 1711: Introduce joining for instructors: send invitation email instead of requiring google ID… #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2895 lines, -450 lines)			Patch
M	src/main/java/teammates/client/scripts/PerformanceProfiler.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/main/java/teammates/common/datatransfer/InstructorAttributes.java	View	1	6 chunks	+23 lines, -5 lines	0 comments	Download
M	src/main/java/teammates/common/util/Const.java	View	1	4 chunks	+15 lines, -2 lines	0 comments	Download
M	src/main/java/teammates/common/util/EmailTemplates.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/main/java/teammates/logic/api/Logic.java	View	1 2 3	12 chunks	+137 lines, -15 lines	0 comments	Download
M	src/main/java/teammates/logic/backdoor/BackDoorLogic.java	View	1	3 chunks	+20 lines, -9 lines	0 comments	Download
M	src/main/java/teammates/logic/backdoor/BackDoorServlet.java	View		4 chunks	+16 lines, -5 lines	0 comments	Download
M	src/main/java/teammates/logic/core/AccountsLogic.java	View		5 chunks	+75 lines, -18 lines	0 comments	Download
M	src/main/java/teammates/logic/core/Emails.java	View		7 chunks	+45 lines, -11 lines	0 comments	Download
M	src/main/java/teammates/logic/core/FeedbackSessionsLogic.java	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/main/java/teammates/logic/core/InstructorsLogic.java	View	1 2 3	7 chunks	+113 lines, -9 lines	0 comments	Download
M	src/main/java/teammates/storage/api/InstructorsDb.java	View		10 chunks	+111 lines, -13 lines	0 comments	Download
M	src/main/java/teammates/storage/entity/Instructor.java	View	1	4 chunks	+47 lines, -6 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/ActionFactory.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/AdminAccountDeleteAction.java	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorCourseEditPageData.java	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorCourseInstructorAddAction.java	View	1	3 chunks	+10 lines, -8 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorCourseInstructorDeleteAction.java	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorCourseInstructorEditSaveAction.java	View		3 chunks	+8 lines, -1 line	0 comments	Download
A	src/main/java/teammates/ui/controller/InstructorCourseJoinAction.java	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	src/main/java/teammates/ui/controller/InstructorCourseJoinAuthenticatedAction.java	View		1 chunk	+74 lines, -0 lines	0 comments	Download
A	src/main/java/teammates/ui/controller/InstructorCourseJoinConfirmationPageData.java	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorCourseRemindAction.java	View		2 chunks	+15 lines, -4 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/PageData.java	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/StudentCourseJoinAuthenticatedAction.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A	src/main/resources/instructorEmailFragment-courseJoin.html	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
R	src/main/resources/studentEmailTemplate-courseJoin.html	View		1 chunk	+0 lines, -10 lines	0 comments	Download
A	src/main/resources/userEmailTemplate-courseJoin.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/main/webapp/js/instructorCourseEdit.js	View		1 chunk	+15 lines, -4 lines	0 comments	Download
M	src/main/webapp/jsp/instructorCourseEdit.jsp	View	1 2 3	2 chunks	+23 lines, -23 lines	0 comments	Download
A	src/main/webapp/jsp/instructorCourseJoinConfirmation.jsp	View		1 chunk	+67 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/cases/common/BuildPropertiesTest.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/test/java/teammates/test/cases/logic/AccountsLogicTest.java	View		10 chunks	+86 lines, -85 lines	0 comments	Download
M	src/test/java/teammates/test/cases/logic/BackDoorLogicTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/java/teammates/test/cases/logic/CoursesLogicTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/java/teammates/test/cases/logic/InstructorsLogicTest.java	View	1 2 3	10 chunks	+152 lines, -12 lines	0 comments	Download
M	src/test/java/teammates/test/cases/logic/LogicTest.java	View	1 2 3	15 chunks	+386 lines, -62 lines	0 comments	Download
M	src/test/java/teammates/test/cases/storage/InstructorsDbTest.java	View	1	6 chunks	+91 lines, -19 lines	0 comments	Download
M	src/test/java/teammates/test/cases/testdriver/BackDoorTest.java	View		8 chunks	+20 lines, -9 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/InstructorCourseInstructorAddActionTest.java	View	1 2 3	5 chunks	+13 lines, -16 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/InstructorCourseInstructorDeleteActionTest.java	View	1 2 3	4 chunks	+16 lines, -15 lines	0 comments	Download
A	src/test/java/teammates/test/cases/ui/InstructorCourseJoinActionTest.java	View		1 chunk	+118 lines, -0 lines	0 comments	Download
A	src/test/java/teammates/test/cases/ui/InstructorCourseJoinAuthenticatedActionTest.java	View		1 chunk	+153 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/AdminAccountDetailsPageUiTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/AllAccessControlUiTests.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorCourseEditPageUiTest.java	View	1	4 chunks	+8 lines, -5 lines	0 comments	Download
A	src/test/java/teammates/test/cases/ui/browsertests/InstructorCourseJoinConfirmationPageUiTest.java	View		1 chunk	+121 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/driver/BackDoor.java	View		3 chunks	+30 lines, -7 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/DevServerLoginPage.java	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/GoogleLoginPage.java	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	src/test/java/teammates/test/pageobjects/InstructorCourseEditPage.java	View		4 chunks	+2 lines, -11 lines	0 comments	Download
A	src/test/java/teammates/test/pageobjects/InstructorCourseJoinConfirmationPage.java	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/LoginPage.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/test/resources/data/InstructorCourseEditPageUiTest.json	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	src/test/resources/data/InstructorCourseJoinConfirmationPageUiTest.json	View		1 chunk	+39 lines, -0 lines	0 comments	Download
M	src/test/resources/data/typicalDataBundle.json	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
A	src/test/resources/pages/InstructorHomeAlreadyJoined.html	View		1 chunk	+207 lines, -0 lines	0 comments	Download
A	src/test/resources/pages/InstructorHomeJoined.html	View		1 chunk	+201 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorCourseDetailsAddInstructor.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorCourseEdit.html	View	1 2 3	3 chunks	+40 lines, -14 lines	0 comments	Download
M	src/test/resources/pages/instructorCourseEditDeleteInstructorSuccessful.html	View	1 2 3	3 chunks	+41 lines, -19 lines	0 comments	Download
A	src/test/resources/pages/instructorHomeInvalidKey.html	View		1 chunk	+160 lines, -0 lines	0 comments	Download