Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1254)

Issue 79690043: Add some tests for local provider destroy

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by thumper
Modified:
10 years, 1 month ago
Reviewers:
mp+212544, axw
Visibility:
Public.

Description

Add some tests for local provider destroy During the force destroy part, forcably remove the mongo and machine agent upstart scripts. Tests are added to show that these are removed. A drive by test was added to show that the containers are destroyed too. https://code.launchpad.net/~thumper/juju-core/better-local-destroy-environ/+merge/212544 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -25 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/local/config_test.go View 1 chunk +1 line, -2 lines 0 comments Download
M provider/local/environ.go View 2 chunks +9 lines, -0 lines 1 comment Download
M provider/local/environ_test.go View 8 chunks +82 lines, -15 lines 0 comments Download
M provider/local/export_test.go View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4
thumper
Please take a look.
10 years, 1 month ago (2014-03-25 04:19:53 UTC) #1
axw
On 2014/03/25 04:19:53, thumper wrote: > Please take a look. Lovely, LGTM.
10 years, 1 month ago (2014-03-25 04:29:45 UTC) #2
axw
Oops, meant to mail this https://codereview.appspot.com/79690043/diff/1/provider/local/environ.go File provider/local/environ.go (right): https://codereview.appspot.com/79690043/diff/1/provider/local/environ.go#newcode443 provider/local/environ.go:443: // Stop the mongo ...
10 years, 1 month ago (2014-03-25 04:29:55 UTC) #3
thumper
10 years, 1 month ago (2014-03-25 05:25:56 UTC) #4
On 2014/03/25 04:29:55, axw wrote:
> Oops, meant to mail this
> 
> https://codereview.appspot.com/79690043/diff/1/provider/local/environ.go
> File provider/local/environ.go (right):
> 
>
https://codereview.appspot.com/79690043/diff/1/provider/local/environ.go#newc...
> provider/local/environ.go:443: // Stop the mongo database. It's possible that
> the service
> // Stop the mongo database and machine agent. It's possible ...
> 
> ?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b