Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(276)

Issue 79550044: add Umbra documentation umbra.dox (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by zhaoqin
Modified:
11 years, 6 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Base URL:
https://drmemory.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fixed issue 1411 add Umbra documentation umbra.dox R=bruening@google.com Committed: https://code.google.com/p/drmemory/source/detail?r=1827

Patch Set 1 #

Total comments: 12

Patch Set 2 : Final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -43 lines) Patch
M docs/CMakeLists.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M docs/Doxyfile.in View 1 1 chunk +1 line, -1 line 0 comments Download
M framework/drmf.dox View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + umbra/umbra.dox View 1 3 chunks +41 lines, -38 lines 0 comments Download

Messages

Total messages: 4
zhaoqin
11 years, 6 months ago (2014-03-25 03:43:43 UTC) #1
bruening
LGTM https://codereview.appspot.com/79550044/diff/1/umbra/umbra.dox File umbra/umbra.dox (left): https://codereview.appspot.com/79550044/diff/1/umbra/umbra.dox#oldcode75 umbra/umbra.dox:75: cmake -G"Ninja" -DDynamoRIO_DIR=c:/path/to/DynamoRIO-Windows-4.1.0-8/cmake -DDrMemoryFramework_DIR=c:/pat/to/DrMemory-Windows-1.6.0-2/drmf ../mysrcs/ can you add ...
11 years, 6 months ago (2014-03-26 05:25:28 UTC) #2
zhaoqin
https://codereview.appspot.com/79550044/diff/1/umbra/umbra.dox File umbra/umbra.dox (left): https://codereview.appspot.com/79550044/diff/1/umbra/umbra.dox#oldcode75 umbra/umbra.dox:75: cmake -G"Ninja" -DDynamoRIO_DIR=c:/path/to/DynamoRIO-Windows-4.1.0-8/cmake -DDrMemoryFramework_DIR=c:/pat/to/DrMemory-Windows-1.6.0-2/drmf ../mysrcs/ On 2014/03/26 05:25:29, bruening ...
11 years, 6 months ago (2014-03-26 21:49:59 UTC) #3
zhaoqin
11 years, 6 months ago (2014-03-26 22:14:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r1827 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b