Change fixedWidth to fixedPitch and implement on Windows.

Change fixedWidth to fixedPitch and implement on Windows.

[bungeman, 2013-03-25 18:27:10]

This change is needed if WebKit is to use Skia on Windows. Currently there
appear to be no callers to isFixedWidth. This changes isFixedWidth to
isFixedPitch to mirror the name of the 'post' table's isFixedPitch field. The
documentation is updated to reflect the fact that that this is a stylistic bit.

[reed1, 2013-03-25 18:32:23]

can we update the parameter names in SkFontHost_FreeType_common.* as well?

https://codereview.appspot.com/7954044/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.appspot.com/7954044/diff/1/include/core/SkTypeface.h#newco...
include/core/SkTypeface.h:210: /** Sets the fixedPitch bit. If used, must be
called in the constructor. */
place after constructor/destructor pair, w/ whitespace

https://codereview.appspot.com/7954044/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.appspot.com/7954044/diff/1/src/ports/SkFontHost_win.cpp#ne...
src/ports/SkFontHost_win.cpp:193: setIsFixedPitch((textMetric.tmPitchAndFamily &
TMPF_FIXED_PITCH) == 0);
nit: this->setIsFixedPitch()

[reed1, 2013-03-25 18:32:52]

https://codereview.appspot.com/7954044/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.appspot.com/7954044/diff/1/include/core/SkTypeface.h#newco...
include/core/SkTypeface.h:209: SkTypeface(Style style, SkFontID uniqueID, bool
isFixedWidth = false);
rename to isFixedPitch

[bungeman, 2013-03-25 19:21:29]

With PS3 we consistently use isFixedPitch for the concept of a font which claims
some sort of monospace-ness. This might be based on 'post' isFixedPitch or
Panose TextAndDisplay Proportion Monospaced. This also adds support on Windows
GDI.

Currently both Windows DirectWrite and FontConfig are always setting this to
'false'. This may or may not be correct.

https://codereview.appspot.com/7954044/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.appspot.com/7954044/diff/1/include/core/SkTypeface.h#newco...
include/core/SkTypeface.h:209: SkTypeface(Style style, SkFontID uniqueID, bool
isFixedWidth = false);
On 2013/03/25 18:32:52, reed1 wrote:
> rename to isFixedPitch

Done.

https://codereview.appspot.com/7954044/diff/1/include/core/SkTypeface.h#newco...
include/core/SkTypeface.h:210: /** Sets the fixedPitch bit. If used, must be
called in the constructor. */
On 2013/03/25 18:32:23, reed1 wrote:
> place after constructor/destructor pair, w/ whitespace

Done.

https://codereview.appspot.com/7954044/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.appspot.com/7954044/diff/1/src/ports/SkFontHost_win.cpp#ne...
src/ports/SkFontHost_win.cpp:193: setIsFixedPitch((textMetric.tmPitchAndFamily &
TMPF_FIXED_PITCH) == 0);
On 2013/03/25 18:32:23, reed1 wrote:
> nit: this->setIsFixedPitch()

Done.

[reed1, 2013-03-25 19:34:59]

lgtm

[bungeman, 2013-03-25 20:04:33]

Committed revision 8372.