Issue 78940044: Don't display 'Feature' for unpromulgated bundles.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 78940044: Don't display 'Feature' for unpromulgated bundles.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by bac

Modified:
10 years, 1 month ago

Reviewers:
jeff.pihach, mp+212242

Visibility:
Public.

Description

Don't display 'Feature' for unpromulgated bundles. https://code.launchpad.net/~bac/charmworld/featuring-nonprom-bundles/+merge/212242 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	charmworld/templates/bundle.pt	View		1 chunk	+12 lines, -10 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM with trivial. https://codereview.appspot.com/78940044/diff/1/charmworld/templates/bundle.pt File charmworld/templates/bundle.pt (right): https://codereview.appspot.com/78940044/diff/1/charmworld/templates/bundle.pt#newcode63 charmworld/templates/bundle.pt:63: </tal:promulgated> I think this indentation is ...

10 years, 1 month ago (2014-03-21 20:48:19 UTC) #2

bac

10 years, 1 month ago (2014-03-21 20:58:46 UTC) #3

Thanks Jeff

https://codereview.appspot.com/78940044/diff/1/charmworld/templates/bundle.pt
File charmworld/templates/bundle.pt (right):

https://codereview.appspot.com/78940044/diff/1/charmworld/templates/bundle.pt...
charmworld/templates/bundle.pt:63: </tal:promulgated>
On 2014/03/21 20:48:19, jeff.pihach wrote:
> I think this indentation is off

Done.

Expand All Messages | Collapse All Messages