Issue 78770045: Patch v8.h to fix FunctionCallbackInfo ambiguity

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 78770045: Patch v8.h to fix FunctionCallbackInfo ambiguity

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by thlorenz

Modified:
10 years, 6 months ago

Reviewers:
dcarney

CC:
thlorenz

Visibility:
Public.

More Reviews

Description

fixes FunctionCallbackInfo ambiguity - when compiling tools that embed v8 with g++ FunctionCallbackInfo is currently ambigous - more info: https://github.com/joyent/node/issues/7337

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	include/v8.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thlorenz

- when compiling tools that embed v8 with g++ FunctionCallbackInfo is currently ambigous - more ...

10 years, 6 months ago (2014-03-22 19:52:14 UTC) #1

dcarney

On 2014/03/22 19:52:14, thlorenz wrote: > - when compiling tools that embed v8 with g++ ...

10 years, 6 months ago (2014-03-23 08:57:22 UTC) #2

landed https://codereview.chromium.org/201573012/

Expand All Messages | Collapse All Messages