Fix local provider upstart

Fix local provider upstart

The local provider upstart script was broken due to
incorrect logging config being written. This branch
also fixes the all machines log symlink.

https://code.launchpad.net/~wallyworld/juju-core/local-provider-upstart/+merge/212101

(do not edit description out of merge proposal)

[wallyworld, 2014-03-21 07:56:45]

Please take a look.

[axw, 2014-03-21 08:23:31]

NOT LGTM without considering how we fix the issue stated below.

It would be useful to know why the service failed to start back up. I can
bootstrap and symlinks are fine, and restarting the service is fine. What's
different about your machine?

https://codereview.appspot.com/78730043/diff/1/provider/local/environ.go
File provider/local/environ.go (right):

https://codereview.appspot.com/78730043/diff/1/provider/local/environ.go#newc...
provider/local/environ.go:144: mcfg.LogDir = env.config.logDir()
I don't think this is right. MachineConfig.LogDir propagates to agent.Config. We
should be also be using that in worker/rsyslog, so we can (when the API version
is complete) get debug-log working on local. Apparmor prevents rsyslog writing
outside of /var/log/..., so this will break when we make that change.

[fwereade, 2014-03-24 10:13:58]

Ian, Andrew: please liaise to figure this out and proceed as appropriate. I'll
WIP it for now.

[axw, 2014-03-24 12:08:32]

On 2014/03/24 10:13:58, fwereade wrote:
> Ian, Andrew: please liaise to figure this out and proceed as appropriate. I'll
> WIP it for now.

Yep, we have been discussing it. I haven't been able to reproduce it. John had
reproduced it, but when I asked him for more information today he was no longer
able to reproduce it. I landed another CL today that simplifies the logic and
adds some missing error checking.