Issue 7872045: Remove dependency on dwmapi.dll.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7872045: Remove dependency on dwmapi.dll. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by apatrick1

Modified:
12 years, 3 months ago

Reviewers:
shannon.woods, shannon.woods%transgaming.com, nicolas, baustin

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove dependency on dwmapi.dll. This code hasn't been used by Chrome since it switched to using shared textures for its presentation path on Vista and later. It will also resolve this: https://codereview.appspot.com/7816046/ Committed: https://code.google.com/p/angleproject/source/detail?r=2002

Patch Set 1 : #

Patch Set 2 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -32 lines)			Patch
M	src/build_angle.gypi	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/libEGL/Surface.cpp	View	1	2 chunks	+0 lines, -20 lines	0 comments	Download
M	src/libEGL/libEGL.vcxproj	View		4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

shannon.woods%transgaming.com

With this removed, I believe Surface.cpp should no longer need to include dwmapi.h. Aside from ...

12 years, 3 months ago (2013-03-20 19:43:58 UTC) #2

Message was sent while issue was closed.

LGTM.  Thanks.

Expand All Messages | Collapse All Messages