Issue 78660043: Add upgrade job for ~ubuntu/.profile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 78660043: Add upgrade job for ~ubuntu/.profile

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by thumper

Modified:
10 years, 1 month ago

Reviewers:
mp+212083, wallyworld

Visibility:
Public.

Description

Add upgrade job for ~ubuntu/.profile The ubuntu user's .profile is updated to source the ~ubuntu/.juju-profile to get the proxy information. The .juju-profile is written out by the machine agent as it starts up if it is missing, but the .profile needs to happen for any machines that were created by older agents. https://code.launchpad.net/~thumper/juju-core/ubuntu-profile-upgrade-step/+merge/212083 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add upgrade job for ~ubuntu/.profile #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -7 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	upgrades/dotprofile.go	View		1 chunk	+37 lines, -0 lines	0 comments	Download
A	upgrades/dotprofile_test.go	View		1 chunk	+82 lines, -0 lines	0 comments	Download
M	upgrades/export_test.go	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	upgrades/steps118.go	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	upgrades/steps118_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

wallyworld

LGTM. I wonder if we should to grep for more than just ".juju-profile", but I ...

10 years, 1 month ago (2014-03-21 04:56:00 UTC) #3

thumper

10 years, 1 month ago (2014-03-21 05:05:39 UTC) #4

On 2014/03/21 04:56:00, wallyworld wrote:
> LGTM. I wonder if we should to grep for more than just ".juju-profile", but I
> guess that is all we need.

Thanks.  The only thing that should have put .juju-profile into the
/home/ubuntu/.profile should have been us.

This is exactly what the cloud-init script does too.

Expand All Messages | Collapse All Messages