code review 786041: pprof: dump extra heap information at end of heap profile

pprof: dump extra heap information at end of heap profile

[rsc, 2010-03-26 22:22:53]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-03-26 22:27:46]

LGTM

On Mar 26, 2010, at 3:22 PM, rsc@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> pprof: dump extra heap information at end of heap profile
>
> Please review this at http://codereview.appspot.com/786041/show
>
> Affected files:
>  M src/pkg/runtime/pprof/pprof.go
>
>
> Index: src/pkg/runtime/pprof/pprof.go
> ===================================================================
> --- a/src/pkg/runtime/pprof/pprof.go
> +++ b/src/pkg/runtime/pprof/pprof.go
> @@ -69,5 +69,29 @@
> 		}
> 		fmt.Fprintf(b, "\n")
> 	}
> +
> +	// Print memstats information too.
> +	// Pprof will ignore, but useful for people.
> +	s := &runtime.MemStats
> +	fmt.Fprintf(b, "\n# runtime.MemStats\n")
> +	fmt.Fprintf(b, "# Alloc = %d\n", s.Alloc)
> +	fmt.Fprintf(b, "# TotalAlloc = %d\n", s.TotalAlloc)
> +	fmt.Fprintf(b, "# Sys = %d\n", s.Sys)
> +	fmt.Fprintf(b, "# Stacks = %d\n", s.Stacks)
> +	fmt.Fprintf(b, "# InusePages = %d\n", s.InusePages)
> +	fmt.Fprintf(b, "# NextGC = %d\n", s.NextGC)
> +	fmt.Fprintf(b, "# HeapAlloc = %d\n", s.HeapAlloc)
> +	fmt.Fprintf(b, "# Lookups = %d\n", s.Lookups)
> +	fmt.Fprintf(b, "# Mallocs = %d\n", s.Mallocs)
> +	fmt.Fprintf(b, "# PauseNs = %d\n", s.PauseNs)
> +	fmt.Fprintf(b, "# NumGC = %d\n", s.NumGC)
> +	fmt.Fprintf(b, "# EnableGC = %v\n", s.EnableGC)
> +	fmt.Fprintf(b, "# DebugGC = %v\n", s.DebugGC)
> +	fmt.Fprintf(b, "# BySize = Size * (Active = Mallocs - Frees)\n")
> +	for _, t := range s.BySize {
> +		if t.Mallocs > 0 {
> +			fmt.Fprintf(b, "#   %d * (%d = %d - %d)\n", t.Size, t.Mallocs- 
> t.Frees, t.Mallocs, t.Frees)
> +		}
> +	}
> 	return b.Flush()
> }
>
>

[rsc, 2010-03-26 22:32:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=add3b3684aeb ***

pprof: dump extra heap information at end of heap profile

R=r
CC=golang-dev
http://codereview.appspot.com/786041