Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 7860047: code review 7860047: crypto/cipher: Added BlockMode for ECB Encryption and D...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by fasmat
Modified:
6 years, 1 month ago
Reviewers:
agl1, agl, rsc
CC:
gobot, golang-dev
Visibility:
Public.

Description

crypto/cipher: Added BlockMode for ECB Encryption and Decryption.

Patch Set 1 #

Patch Set 2 : diff -r 419dcca62a3d https://code.google.com/p/go #

Patch Set 3 : diff -r 419dcca62a3d https://code.google.com/p/go #

Patch Set 4 : diff -r 419dcca62a3d https://code.google.com/p/go #

Patch Set 5 : diff -r 419dcca62a3d https://code.google.com/p/go #

Patch Set 6 : diff -r 6dad366e9f94 https://code.google.com/p/go #

Patch Set 7 : diff -r 6dad366e9f94 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -1 line) Patch
A src/pkg/crypto/cipher/ecb.go View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A src/pkg/crypto/cipher/ecb_aes_test.go View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
M src/pkg/crypto/cipher/example_test.go View 1 2 3 4 2 chunks +64 lines, -1 line 0 comments Download

Messages

Total messages: 9
fasmat
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
6 years, 10 months ago (2013-03-24 11:58:21 UTC) #1
rsc
Sorry, but we're not adding new API again until after Go 1.1 is released. Please ...
6 years, 10 months ago (2013-03-25 00:23:54 UTC) #2
gobot
R=agl (assigned by dsymonds)
6 years, 9 months ago (2013-04-18 02:52:49 UTC) #3
fasmat
Hello agl@chromium.org (cc: gobot@golang.org, golang-dev@googlegroups.com, rsc@golang.org), Please take another look.
6 years, 7 months ago (2013-06-03 22:54:20 UTC) #4
agl1
ECB is deliberately not included because it's so vulnerable and easy to implement yourself if ...
6 years, 7 months ago (2013-06-03 22:56:19 UTC) #5
fasmat
On 2013/06/03 22:56:19, agl1 wrote: > ECB is deliberately not included because it's so vulnerable ...
6 years, 7 months ago (2013-06-03 23:04:32 UTC) #6
rsc
I don't think we can be any clearer: Thank you for the effort, but sorry, ...
6 years, 7 months ago (2013-06-04 01:05:21 UTC) #7
agl
On Mon, Jun 3, 2013 at 7:04 PM, <fasching.matthias@gmail.com> wrote: > 1. It is the ...
6 years, 7 months ago (2013-06-04 16:46:23 UTC) #8
rsc
6 years, 1 month ago (2013-12-18 20:13:24 UTC) #9
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b