Issue 782041: code review 782041: runtime: run all finalizers in a single goroutine.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 782041: code review 782041: runtime: run all finalizers in a single goroutine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by rsc

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

runtime: run all finalizers in a single goroutine. eliminate second pass of mark+sweep by scanning finalizer table specially.

Patch Set 1 #

Patch Set 2 : code review 782041: runtime: run all finalizers in a single goroutine. #

Patch Set 3 : code review 782041: runtime: run all finalizers in a single goroutine. #

Patch Set 4 : code review 782041: runtime: run all finalizers in a single goroutine. #

Patch Set 5 : code review 782041: runtime: run all finalizers in a single goroutine. #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -125 lines)			Patch
M	src/pkg/runtime/extern.go	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/malloc.h	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/malloc.cgo	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mfinal.c	View		6 chunks	+38 lines, -22 lines	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1 2 3 4	11 chunks	+93 lines, -94 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2 3 4	3 chunks	+4 lines, -1 line	0 comments	Download
M	test/mallocfin.go	View	1 2	3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-03-26 20:59:02 UTC) #1

rsc

14 years, 11 months ago (2010-03-26 21:15:32 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=807317511642 ***

runtime: run all finalizers in a single goroutine.
eliminate second pass of mark+sweep
by scanning finalizer table specially.

R=r
CC=golang-dev
http://codereview.appspot.com/782041

Expand All Messages | Collapse All Messages