Issue 7812045: Enable dead_belowdot with de layout.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7812045: Enable dead_belowdot with de layout. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by fujiwara

Modified:
11 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus-qt.git@master

Visibility:
Public.

More Reviews

Description

Enable dead_belowdot with de layout. AltGr + j returns dead_belowdot in de layout. E.g. AltGr + j, s returns U+1E63 with de. XLookupString can get dead_belowdot but the return value is 0. I think XLookupString does not failed with return value 0. BUG=RH#921164

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	qtim/ibus-input-context.cpp	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

LGTM with a comment. Could you please add more detail in CL description. https://codereview.appspot.com/7812045/diff/1/qtim/ibus-input-context.cpp File ...

11 years, 2 months ago (2013-03-15 16:26:48 UTC) #2

fujiwara

11 years, 2 months ago (2013-03-18 04:14:38 UTC) #3

https://codereview.appspot.com/7812045/diff/1/qtim/ibus-input-context.cpp
File qtim/ibus-input-context.cpp (right):

https://codereview.appspot.com/7812045/diff/1/qtim/ibus-input-context.cpp#new...
qtim/ibus-input-context.cpp:261: (KeySym *)keyval)) {
On 2013/03/15 16:26:48, Peng wrote:
> Is it a workaround? Will you remove it when XLookupKeysym is fixed?
> If so, I think it is better to add a /* TODO */ here with the upstream bug id.

After we discussed this issue, ibus-qt will use XLookupString even if the return
value is 0 to follow gtkxim.

Expand All Messages | Collapse All Messages