Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)

Issue 779041: Module sale_opportunity (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by ced
Modified:
10 years, 10 months ago
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix typo #

Patch Set 3 : Remove swap file #

Patch Set 4 : Add opportunities to sale orders #

Total comments: 1

Patch Set 5 : Fix colspan #

Patch Set 6 : Add warehouse and payment_term on opportunity to create sale #

Patch Set 7 : Update #

Total comments: 1

Patch Set 8 : Add report per employee #

Patch Set 9 : Add two more reports #

Patch Set 10 : Add rates on reports #

Total comments: 3

Patch Set 11 : Add help on amount #

Patch Set 12 : Fix date precision in history to prevent wrong change detection in the client #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1867 lines, -0 lines) Patch
A COPYRIGHT View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +16 lines, -0 lines 0 comments Download
A INSTALL View 1 chunk +33 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +11 lines, -0 lines 0 comments Download
A README View 1 chunk +36 lines, -0 lines 0 comments Download
A __init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A __tryton__.py View 1 2 3 4 5 6 1 chunk +31 lines, -0 lines 1 comment Download
A opportunity.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +846 lines, -0 lines 0 comments Download
A opportunity.xml View 1 2 3 4 5 6 7 8 9 1 chunk +766 lines, -0 lines 0 comments Download
A party.xml View 1 chunk +20 lines, -0 lines 0 comments Download
A setup.py View 1 chunk +63 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/test_sale_opportunity.py View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 38
ced
11 years, 3 months ago (2010-03-26 17:18:14 UTC) #1
yangoon1
swapfile in tests by accident. http://codereview.appspot.com/779041/diff/1/8 File __tryton__.py (right): http://codereview.appspot.com/779041/diff/1/8#newcode9 __tryton__.py:9: 'description': '''Sales extension Provides: ...
11 years, 3 months ago (2010-03-26 17:47:01 UTC) #2
ced
11 years, 3 months ago (2010-03-26 17:56:40 UTC) #3
ced
11 years, 3 months ago (2010-03-26 18:03:25 UTC) #4
sharoonthomas
http://codereview.appspot.com/779041/diff/1/8 File __tryton__.py (right): http://codereview.appspot.com/779041/diff/1/8#newcode13 __tryton__.py:13: - Record of lost leads now includes oppportunities to ...
11 years, 3 months ago (2010-03-26 18:33:13 UTC) #5
ced
11 years, 3 months ago (2010-03-26 18:56:14 UTC) #6
yangoon1
After installing the module I have a question: A lead could also be a contract, ...
11 years, 3 months ago (2010-03-26 19:34:25 UTC) #7
ced
On 2010/03/26 19:34:25, yangoon wrote: > After installing the module I have a question: > ...
11 years, 3 months ago (2010-03-28 09:57:25 UTC) #8
yangoon1
On 2010/03/28 09:57:25, ced wrote: > On 2010/03/26 19:34:25, yangoon wrote: > > After installing ...
11 years, 3 months ago (2010-03-28 19:46:56 UTC) #9
ced
On 2010/03/28 19:46:56, yangoon wrote: > On 2010/03/28 09:57:25, ced wrote: > > On 2010/03/26 ...
11 years, 3 months ago (2010-03-28 20:21:22 UTC) #10
yangoon1
On 2010/03/28 20:21:22, ced wrote: > On 2010/03/28 19:46:56, yangoon wrote: > > On 2010/03/28 ...
11 years, 3 months ago (2010-03-28 21:29:08 UTC) #11
yangoon1
http://codereview.appspot.com/779041/diff/13001/14008 File opportunity.py (right): http://codereview.appspot.com/779041/diff/13001/14008#newcode61 opportunity.py:61: 'History') Should be set ot readonly to avoid display ...
11 years, 3 months ago (2010-03-28 21:41:52 UTC) #12
ced
On 2010/03/28 21:29:08, yangoon wrote: > On 2010/03/28 20:21:22, ced wrote: > > On 2010/03/28 ...
11 years, 3 months ago (2010-03-28 21:59:46 UTC) #13
ced
11 years, 3 months ago (2010-03-28 21:59:53 UTC) #14
ced
11 years, 2 months ago (2010-03-30 17:41:47 UTC) #15
ced
11 years ago (2010-05-29 21:15:33 UTC) #16
timitos
When i click on a record in the list of history i get the following ...
11 years ago (2010-06-12 16:39:05 UTC) #17
ced
On 2010/06/12 16:39:05, timitos wrote: > When i click on a record in the list ...
11 years ago (2010-06-12 17:50:03 UTC) #18
timitos
On 2010/06/12 17:50:03, ced wrote: > On 2010/06/12 16:39:05, timitos wrote: > > When i ...
11 years ago (2010-06-12 18:07:11 UTC) #19
ced
On 2010/06/12 17:50:03, ced wrote: > On 2010/06/12 16:39:05, timitos wrote: > > When i ...
11 years ago (2010-06-12 18:07:32 UTC) #20
ced
On 2010/06/12 18:07:32, ced wrote: > On 2010/06/12 17:50:03, ced wrote: > > On 2010/06/12 ...
11 years ago (2010-06-12 18:17:52 UTC) #21
timitos
On 2010/06/12 18:07:32, ced wrote: > On 2010/06/12 17:50:03, ced wrote: > > On 2010/06/12 ...
11 years ago (2010-06-12 18:19:26 UTC) #22
ced
On 2010/06/12 18:19:26, timitos wrote: > On 2010/06/12 18:07:32, ced wrote: > > On 2010/06/12 ...
11 years ago (2010-06-12 18:21:01 UTC) #23
timitos
i was able to produce another error: Traceback (most recent call last): File "/trytond/protocols/netrpc.py", line ...
11 years ago (2010-06-13 14:38:15 UTC) #24
ced
11 years ago (2010-06-20 20:34:38 UTC) #25
ced
10 years, 12 months ago (2010-07-01 18:43:21 UTC) #26
timitos
i found one issue: When i open the history and change after this for example ...
10 years, 12 months ago (2010-07-02 07:36:04 UTC) #27
ced
On 2010/07/02 07:36:04, timitos wrote: > i found one issue: > When i open the ...
10 years, 12 months ago (2010-07-02 07:41:17 UTC) #28
ced
10 years, 11 months ago (2010-07-03 17:58:04 UTC) #29
ced
10 years, 11 months ago (2010-07-03 21:03:48 UTC) #30
udono
Works on postgres and tip http://codereview.appspot.com/779041/diff/45001/46007 File opportunity.py (right): http://codereview.appspot.com/779041/diff/45001/46007#newcode45 opportunity.py:45: depends=['currency_digits']) Here we could ...
10 years, 11 months ago (2010-07-04 09:36:50 UTC) #31
udono
http://codereview.appspot.com/779041/diff/62001/63008 File opportunity.xml (right): http://codereview.appspot.com/779041/diff/62001/63008#newcode748 opportunity.xml:748: </record> Only a tree action?
10 years, 11 months ago (2010-07-04 09:40:48 UTC) #32
ced
http://codereview.appspot.com/779041/diff/62001/63008 File opportunity.xml (right): http://codereview.appspot.com/779041/diff/62001/63008#newcode748 opportunity.xml:748: </record> On 2010/07/04 09:40:48, udono wrote: > Only a ...
10 years, 11 months ago (2010-07-04 10:01:20 UTC) #33
udono
http://codereview.appspot.com/779041/diff/62001/63008 File opportunity.xml (right): http://codereview.appspot.com/779041/diff/62001/63008#newcode748 opportunity.xml:748: </record> On 2010/07/04 10:01:20, ced wrote: > On 2010/07/04 ...
10 years, 11 months ago (2010-07-04 10:30:35 UTC) #34
ced
10 years, 11 months ago (2010-07-04 18:04:03 UTC) #35
udono
Looks good!
10 years, 11 months ago (2010-07-04 19:34:17 UTC) #36
ced
10 years, 11 months ago (2010-07-04 20:47:48 UTC) #37
sharoonthomas
10 years, 10 months ago (2010-08-04 09:31:53 UTC) #38
My own bug!

http://codereview.appspot.com/779041/diff/73001/47009
File __tryton__.py (right):

http://codereview.appspot.com/779041/diff/73001/47009#newcode5
__tryton__.py:5: 'version': '0.0.1',
The version number is wrong, this will cause setup.py to crash because it will
split and search for the wrong version of tryton.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b