Issue 77650044: Issue 1730 : handle cases where email API timeout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77650044: Issue 1730 : handle cases where email API timeout

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by leeshawn89

Modified:
10 years, 5 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1730 : handle cases where email API timeout

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 1730 : handle cases where email API timeout #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -6 lines)			Patch
M	src/main/java/teammates/common/util/Const.java	View	1	4 chunks	+8 lines, -1 line	0 comments	Download
A	src/main/java/teammates/logic/automated/SendEmailWorkerServlet.java	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/logic/core/Emails.java	View	1	2 chunks	+26 lines, -4 lines	0 comments	Download
M	src/main/webapp/WEB-INF/queue.xml	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	src/main/webapp/WEB-INF/web.xml	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 5 months ago (2014-03-23 23:37:45 UTC) #1

https://codereview.appspot.com/77650044/diff/1/src/main/java/teammates/common...
File src/main/java/teammates/common/util/Const.java (right):

https://codereview.appspot.com/77650044/diff/1/src/main/java/teammates/common...
src/main/java/teammates/common/util/Const.java:39: public static final String
SEND_EMAIL_TASK_QUEUE = "send-email-queue";
Now we have two email related queues. Name them well so that the difference is
apparent.

https://codereview.appspot.com/77650044/diff/1/src/main/java/teammates/common...
src/main/java/teammates/common/util/Const.java:345: public static final String
EMAIL_REPLY = "reply";
Be more specific. e.g. EMAIL_SENDER_ADDRESS

https://codereview.appspot.com/77650044/diff/1/src/main/java/teammates/logic/...
File src/main/java/teammates/logic/automated/SendEmailWorkerServlet.java
(right):

https://codereview.appspot.com/77650044/diff/1/src/main/java/teammates/logic/...
src/main/java/teammates/logic/automated/SendEmailWorkerServlet.java:58: }
There seems to be an indentation problem here.

https://codereview.appspot.com/77650044/diff/1/src/main/webapp/WEB-INF/queue.xml
File src/main/webapp/WEB-INF/queue.xml (right):

https://codereview.appspot.com/77650044/diff/1/src/main/webapp/WEB-INF/queue....
src/main/webapp/WEB-INF/queue.xml:84: </retry-parameters>
For the retry to work, I think you need to set some error code when the task
fails. Look into it.

Expand All Messages | Collapse All Messages