Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(617)

Issue 77480045: Use intrinsic functions for bit counting to reduce footprint (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Olle Liljenzin
Modified:
10 years, 8 months ago
Reviewers:
noel1, noel chromium
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Visibility:
Public.

Description

Use intrinsic functions for bit counting to reduce footprint The clz/bsr instructions produce the same result as the lookup table "jpeg_nbits_table" with equivalent performance. Removing the table saves 64kB. It is not much, but for mobile devices we need to save all memory that is possible. This change is for gcc and clang compilers. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M jchuff.c View 5 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 7
Olle Liljenzin
10 years, 10 months ago (2014-03-19 12:37:02 UTC) #1
Olle Liljenzin
Upstreaming to sourceforge: https://sourceforge.net/p/libjpeg-turbo/patches/57/
10 years, 10 months ago (2014-03-20 11:15:41 UTC) #2
noel chromium
Thanks Olle. Let's await news from upstream.
10 years, 10 months ago (2014-03-21 01:06:07 UTC) #3
Olle Liljenzin
On 2014/03/21 01:06:07, noel chromium wrote: > Thanks Olle. Let's await news from upstream. The ...
10 years, 9 months ago (2014-04-07 15:11:28 UTC) #4
noel chromium
Ok thanks Olle, I intend to update libjpeg_turbo to 1.3.1 stable (r1219) to bring our ...
10 years, 9 months ago (2014-04-12 07:18:11 UTC) #5
Olle Liljenzin
Created new review that cherry-picks the upstream patch: https://codereview.appspot.com/97690043/
10 years, 8 months ago (2014-05-22 15:11:29 UTC) #6
noel chromium
10 years, 8 months ago (2014-05-23 12:22:06 UTC) #7
Message was sent while issue was closed.
On 2014/05/22 15:11:29, Olle Liljenzin wrote:
> Created new review that cherry-picks the upstream patch:
> https://codereview.appspot.com/97690043/

Thanks. Let's continue to work there (and close this issue if you no longer need
it).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b