Issue 77340046: Add --proxy option to "juju ssh"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77340046: Add --proxy option to "juju ssh"

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by axw

Modified:
10 years, 1 month ago

Reviewers:
mp+211662, thumper

Visibility:
Public.

Description

Add --proxy option to "juju ssh" juju ssh will now, by default, proxy connections through the API server host. I have not yet implemented support for the ProxyCommand option for the go.crypto/ssh client; this will be done as a follow up. https://code.launchpad.net/~axwalk/juju-core/ssh-proxycommand/+merge/211662 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+300 lines, -89 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/scp.go	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	cmd/juju/scp_test.go	View	2 chunks	+56 lines, -58 lines	0 comments	Download
M	cmd/juju/ssh.go	View	9 chunks	+74 lines, -11 lines	0 comments	Download
M	cmd/juju/ssh_test.go	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	juju/api.go	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	juju/apiconn_test.go	View	12 chunks	+13 lines, -13 lines	0 comments	Download
M	juju/export_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/apiclient.go	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	state/api/client.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	state/api/params/params.go	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	state/apiserver/client/client.go	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View	1 chunk	+60 lines, -0 lines	0 comments	Download
M	utils/ssh/ssh.go	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	utils/ssh/ssh_openssh.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

LGTM - the code looks fine, and I'm assuming you have tested it.

10 years, 1 month ago (2014-03-19 03:41:35 UTC) #2

axw

10 years, 1 month ago (2014-03-19 04:45:36 UTC) #3

On 2014/03/19 03:41:35, thumper wrote:
> LGTM - the code looks fine, and I'm assuming you have tested it.

Tested with local, canonistack and azure. Verified that ssh, scp, debug-log, and
debug-hooks.

Expand All Messages | Collapse All Messages