Issue 7730043: code review 7730043: reflect: avoid allocation during Type.Field

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7730043: code review 7730043: reflect: avoid allocation during Type.Field (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by bradfitz

Modified:
12 years, 10 months ago

Reviewers:
rsc, golang-dev

Visibility:
Public.

reflect: avoid allocation during Type.Field

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -8 lines)			Patch
		src/pkg/reflect/all_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
		src/pkg/reflect/type.go	View	1	2 chunks	+34 lines, -8 lines	0 comments	Download

Total messages: 2

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2013-03-11 22:01:54 UTC) #1

rsc

12 years, 10 months ago (2013-03-11 22:04:17 UTC) #2

Sorry, but I want real safety. The allocations are not that bad anymore.