Issue 77090043: only check for is object on instance (not prototype)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77090043: only check for is object on instance (not prototype) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rafaelw

Modified:
11 years, 1 month ago

Reviewers:
arv, rafaelw1, John Messerly

Base URL:
https://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

only check for is object on instance (not prototype) R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/5db3ef5

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/observe.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rafaelw

I realize this will miss the case of having (e.g) a number on the prototype ...

11 years, 1 month ago (2014-03-17 21:23:41 UTC) #1

rafaelw

Committed patchset #1 manually as r5db3ef5 (presubmit successful).

11 years, 1 month ago (2014-03-17 21:23:54 UTC) #2

arv

LGTM The [[Prototype]] cannot be a number. Only objects and null allowed.

11 years, 1 month ago (2014-03-24 17:04:05 UTC) #4

rafaelw1

11 years, 1 month ago (2014-03-24 17:18:57 UTC) #5

Even better!


On Mon, Mar 24, 2014 at 10:04 AM, <arv@chromium.org> wrote:

> LGTM
>
> The [[Prototype]] cannot be a number. Only objects and null allowed.
>
> https://codereview.appspot.com/77090043/
>

Expand All Messages | Collapse All Messages