Issue 77020045: Issue 1729:instructorFeedbackSessionEdit/DeleteComment: use AJAX to edit and delete comment

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 77020045: Issue 1729:instructorFeedbackSessionEdit/DeleteComment: use AJAX to edit and delete comment (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by arnold.koroa

Modified:
10 years, 5 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1729:instructorFeedbackSessionEdit/DeleteComment: use AJAX to edit and delete comment

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -122 lines)			Patch
M	src/main/java/teammates/logic/api/Logic.java	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/logic/core/FeedbackResponseCommentsLogic.java	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackResponseCommentAddAction.java	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackResponseCommentAjaxPageData.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackResponseCommentDeleteAction.java	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/InstructorFeedbackResponseCommentEditAction.java	View	3 chunks	+12 lines, -21 lines	0 comments	Download
M	src/main/webapp/js/common.js	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	src/main/webapp/js/feedbackResponseComments.js	View	3 chunks	+146 lines, -15 lines	0 comments	Download
M	src/main/webapp/jsp/instructorFeedbackResultsByRecipient.jsp	View	3 chunks	+5 lines, -8 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/InstructorFeedbackResponseCommentAddActionTest.java	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/InstructorFeedbackResponseCommentDeleteActionTest.java	View	3 chunks	+7 lines, -10 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/InstructorFeedbackResponseCommentEditActionTest.java	View	3 chunks	+11 lines, -18 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackResultsPageUiTest.java	View	3 chunks	+43 lines, -5 lines	1 comment	Download
M	src/test/java/teammates/test/pageobjects/InstructorFeedbackResultsPage.java	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsPageOpen.html	View	12 chunks	+11 lines, -12 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackResultsSortRecipient.html	View	12 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 6 months ago (2014-03-19 09:50:43 UTC) #1

https://codereview.appspot.com/77020045/diff/1/src/test/java/teammates/test/c...
File
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackResultsPageUiTest.java
(right):

https://codereview.appspot.com/77020045/diff/1/src/test/java/teammates/test/c...
src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackResultsPageUiTest.java:228:
}
This one is a bit convoluted. May be abstract into verifyRowMissing(...)?

Expand All Messages | Collapse All Messages